[Bug 9675] New: Replace YUI buttons on authorities home page with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Bug ID: 9675 Summary: Replace YUI buttons on authorities home page with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar include file (authorities-toolbar.inc) used by the authorities home page uses YUI for buttons and button menus. It should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15573&action=edit Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Ooops. Does not apply. Seems that your authorities-toolbar.inc is not the same as master's. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15598&action=edit Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Sorry about that -- I missed a commit in an interactive rebase. Please try again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15598|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15599&action=edit [SIGNED-OFF] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Now it works. New and all operations on existing auth works. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15599|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15828&action=edit [PASSED QA] Bug 9675 - Replace YUI buttons on authorities home page with Bootstrap This patch converts the toolbar include file used by the authorities home page and authority view page (authorities-home.pl and authorities/detail.pl) replacing YUI button and menu code with Bootstrap. To test: - View the authorities home page and confirm that the "New authority" button looks correct and works correctly. - Search for an existing authority and click the "Details" link to view. "Edit," "Delete," "Save," and "New authority" buttons should look correct and work correctly. The "Delete" button should only appear for authorities which are unused. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Now it works. New and all operations on existing auth works. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was a bit surprised that the "New" pull down is last on an authority detail page as it's normally the first on other pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9675 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org