https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127539|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 127828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127828&action=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #3)

Looks way better :D

In opac-auth, with should also fix : You may register here. instead of Don't have an account? Register here.

Maybe in another bug.

Please open another bug. Can we get this one further please ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- I opened Bug 29730 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #6)

Please rebase. It like it but doesn't apply.

Easy fix :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Owen, could you have a look at the second patch? Would you suggest to add a class and additional css or so instead? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #9)

+ <div class="">[%# FIXME Add right class, remove br %] + <br>

Easy fixme, should be implemented here.

Fixed now with help from Owen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129240|0 |1 is obsolete| | Attachment #129612|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129617&action=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Bug 29458: (follow-up) Remove FIXME With some help of Owen Leonard: <oleonard> Regarding the <br/>, you can wrap the submit button in <fieldset class="action"></fieldset> instead. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #16)

Selenium authentication tests are failing because of this change: Error while executing command: element not interactable: Element <input class="btn btn-primary" type="submit"> could not be scrolled into view at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356.

Which test specifically ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 130016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130016&action=edit Bug 29458: Fix selenium test The authentication.t selenium tests (and a couple of others) were failing with: Error while executing command: element not interactable: Element <input class="btn btn-primary" type="submit"> could not be scrolled into view at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356. We changed the other of the form, and t::lib::Selenium::submit_form was not getting the correct (first) form. The one from the auth modal was retrieved and submit button was clicked. Selenium raised an error as it is not displayed. The ->is_displayed selenium method does not work, as per the doc """ Note: This does *not* tell you an element's 'visibility' property; as it still takes up space in the DOM and is therefore considered 'displayed'. """ https://metacpan.org/pod/Selenium::Remote::WebElement#is_displayed "The internet" is saying we should be able to use the following in our xpath expression: not(ancestor::div[contains(@style,'display:none')] but it actually only works if the display:none rule is defined on the node (not from .css). Which does not work for us. The only solution I found is to check for the size of the element, which is (0,0) if not effectively displayed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #19)

Created attachment 130016 [details] [review] Bug 29458: Fix selenium test

The authentication.t selenium tests (and a couple of others) were failing with: Error while executing command: element not interactable: Element <input class="btn btn-primary" type="submit"> could not be scrolled into view at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356.

We changed the other of the form, and t::lib::Selenium::submit_form was not getting the correct (first) form. The one from the auth modal was retrieved and submit button was clicked. Selenium raised an error as it is not displayed. The ->is_displayed selenium method does not work, as per the doc """ Note: This does *not* tell you an element's 'visibility' property; as it still takes up space in the DOM and is therefore considered 'displayed'. """ https://metacpan.org/pod/Selenium::Remote::WebElement#is_displayed

"The internet" is saying we should be able to use the following in our xpath expression: not(ancestor::div[contains(@style,'display:none')] but it actually only works if the display:none rule is defined on the node (not from .css). Which does not work for us.

The only solution I found is to check for the size of the element, which is (0,0) if not effectively displayed.

Thanks. Too bad that we need such workarounds. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #22)

Change status to ?

No need to, there is the additional_work_needed keyword. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> ---

Bug 29458: Fix selenium test Pushed to master

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064 [Bug 31064] Local login is difficult to style using CSS -- You are receiving this mail because: You are watching all bug changes.