[Bug 31086] New: Do not allow hold requests with no branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Bug ID: 31086 Summary: Do not allow hold requests with no branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Holds require a branchcode, various code expects this, however, we do not enforce this requirement when saving holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136983&action=edit Bug 31086: DB update This update sets branchcode as NOT NULL default set to 0 as borrowernumber is -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136984&action=edit Bug 31086: Throw an exception when a hold is stored with no branchcode To test: 1 - Apply first 2 patches 2 - On staff client, find a biblio, place hold, select a patron 3 - Before creating hold, right click on 'Pickup location' 4 - Inspect the element 5 - In the console find the top <li> for pickup, and right click 6 - Select 'Delete node' 7 - Save hold 8 - You get an exception/error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136986&action=edit Bug 31086: Prevent placing hold with no pickup location To test: 1 - Apply patch 2 - Repeat test on previous patch 3 - You should get a warning popup when attempting to save hold 4 - Reload page 5 - Inspect the HTML and manualy set #pickup value of selected option to "" 6 - Attempt to save hold 7 - You get the popup 8 - Place a hold normally (with location) and verify it works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136987&action=edit Bug 31086: DO NOT PUSH: Schema updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 137026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137026&action=edit Bug 31086: Update existing unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Carolyn Hughesman <chughesman@cclsny.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman@cclsny.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136983|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 137254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137254&action=edit Bug 31086: DB update This update sets branchcode as NOT NULL default set to 0 as borrowernumber is Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136984|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 137255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137255&action=edit Bug 31086: Throw an exception when a hold is stored with no branchcode To test: 1 - Apply first 2 patches 2 - On staff client, find a biblio, place hold, select a patron 3 - Before creating hold, right click on 'Pickup location' 4 - Inspect the element 5 - In the console find the top <li> for pickup, and right click 6 - Select 'Delete node' 7 - Save hold 8 - You get an exception/error Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136986|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 137256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137256&action=edit Bug 31086: Prevent placing hold with no pickup location To test: 1 - Apply patch 2 - Repeat test on previous patch 3 - You should get a warning popup when attempting to save hold 4 - Reload page 5 - Inspect the HTML and manualy set #pickup value of selected option to "" 6 - Attempt to save hold 7 - You get the popup 8 - Place a hold normally (with location) and verify it works Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136987|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 137257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137257&action=edit Bug 31086: DO NOT PUSH: Schema updates Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137026|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 137258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137258&action=edit Bug 31086: Update existing unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 137254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137254 Bug 31086: DB update Review of attachment 137254: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31086&attachment=137254) ----------------------------------------------------------------- ::: installer/data/mysql/kohastructure.sql @@ +4408,4 @@
`borrowernumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key from the borrowers table defining which patron this hold is for', `reservedate` date DEFAULT NULL COMMENT 'the date the hold was placed', `biblionumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key from the biblio table defining which bib record this hold is on', + `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 0 COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at',
Why DEFAULT 0? We're throwing an exception if we don't pass a branchcode in the app... why default to a probably incorrect branch id in SQL.. to me I'd just drop the DEFAULT entirely and force anyone writing SQL to get thrown an error when they don't include it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137254|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137635&action=edit Bug 31086: DB update This update sets branchcode as NOT NULL default set to 0 as borrowernumber is Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137255|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137636&action=edit Bug 31086: Throw an exception when a hold is stored with no branchcode To test: 1 - Apply first 2 patches 2 - On staff client, find a biblio, place hold, select a patron 3 - Before creating hold, right click on 'Pickup location' 4 - Inspect the element 5 - In the console find the top <li> for pickup, and right click 6 - Select 'Delete node' 7 - Save hold 8 - You get an exception/error Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137256|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137637&action=edit Bug 31086: Prevent placing hold with no pickup location To test: 1 - Apply patch 2 - Repeat test on previous patch 3 - You should get a warning popup when attempting to save hold 4 - Reload page 5 - Inspect the HTML and manualy set #pickup value of selected option to "" 6 - Attempt to save hold 7 - You get the popup 8 - Place a hold normally (with location) and verify it works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137257|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137638&action=edit Bug 31086: DO NOT PUSH: Schema updates Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137258|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137639&action=edit Bug 31086: Update existing unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137640&action=edit Bug 31086: (QA follow-up) Remove DEFAULT from column There's no need to have a default here, and in fact it doesn't make sense. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137641&action=edit Bug 31086: (QA follow-up) Fix failing tests This test was missed first time around, branchcode needed adding to all the calls to AddReserve. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137642&action=edit Bug 31086: (QA follow-up) Add unit tests This patch adds the unit tests for the change to Koha::Hold::store. We test for and catch the exception introduced for both the create and update cases. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All good now with the minor follow-ups.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- - It feels weird that we add a DB-level constraint on the column, but we manually check it in ->store to raise the exception. I see how we got there by the bug history. Thoughts? Shouldn't we catch the DB-level exception and throw our own? Not a blocker, though. - In cases like this, if the atomicupdate fails, it would be nice to tell how to fix things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good points raised there Tomas.. I was perhaps a little hasty in PQA. We could do better; as you highlighted we could be catching the constraint failure rather than testing before hitting the database.. never sure which approach is actually cleaner/better for performance.. it would be interesting to benchmark that. However, the DB update side is something I think we probably should try to improve by making it a little more resilient.. we could look for nulls prior to adding the constraint and arbitrarily pick the first branchcode in the branches table to fix the data should we find any nulls? Our database updates are better now in terms of not silently ignoring issues, but I do think we as Devs aught to try and cater for more of these cases to keep the upgrades fairly smooth. I'm happy to add that proposed follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Martin Renvoize from comment #22)
Our database updates are better now in terms of not silently ignoring issues, but I do think we as Devs aught to try and cater for more of these cases to keep the upgrades fairly smooth.
I'm happy to add that proposed follow-up
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138006&action=edit Bug 31086: (QA follow-up) Improve atomicupdate to be more resilient We now populate the branchcode field with the first available branch on the system if we find it to be NULL before we set the NOT NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138018&action=edit Bug 31086: Notify of problematic holds during upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like nicks addition to my follow-up.. best of all worlds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138051&action=edit Bug 31086: (QA follow-up) Use plain SQL in db_rev Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- This patchset won't apply cleanly to 22.05.x. If needed, please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #30 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #29)
This patchset won't apply cleanly to 22.05.x. If needed, please rebase.
Nevermind, this actually applied cleanly. Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00,21.11, 22.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #31 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 José Anjos <joseanjos@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- CC| |joseanjos@gmail.com --- Comment #33 from José Anjos <joseanjos@gmail.com> --- I think this is related: Updating database structure Update errors : Upgrade to 22.05.04.002 [10:09:24]: Bug 31086 - Do not allow null values in branchcodes for reserves ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'branchcode': used in a foreign key constraint 'reserves_ibfk_4' at /usr/share/koha/lib/C4/Installer.pm line 739 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 José Anjos <joseanjos@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #34 from José Anjos <joseanjos@gmail.com> --- After manually doing this command: ALTER TABLE reserves MODIFY COLUMN `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at'; Query OK, 0 rows affected (0.06 sec) Records: 0 Duplicates: 0 Warnings: 0 it was possible to continue with the upgrade... Strange -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31673 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31673 [Bug 31673] DB update of bug 31086 fails: Cannot change column 'branchcode': used in a foreign key constraint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't understand how running the exact same SQL as is in the update itself can resolve this problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #35)
I don't understand how running the exact same SQL as is in the update itself can resolve this problem.
Fixed on bug 31673. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144824&action=edit Bug 31086: (follow-up) There's no ->fill in 21.11 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31086 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #38 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org