[Bug 15327] New: Minor tweaks to Bootstrap modal handling on Staged MARC management page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Bug ID: 15327 Summary: Minor tweaks to Bootstrap modal handling on Staged MARC management page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/manage-marc-import.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I have a few tweaks to the way the Bootstrap modal is handled on Staged MARC management page. - Use the prettier "html" format for the data preview - Remove some obsolete code left over from when the page used Greybox -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45467&action=edit Bug 15327 - Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45467|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45472&action=edit [SIGNED-OFF]Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Modal looks much better. Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45472|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45485&action=edit Bug 15327: Minor tweaks to Bootstrap modal handling on Staged MARC management page This patch makes a couple of minor corrections to the template for staged MARC management. The MARC preview is now formatted using the "html" option, and some obsolete Greybox-related code has been removed. To test: 1. Apply the patch and go to Tools -> Staged MARC management. 2. Click any staged MARC file containing multiple records. 3. Click the title in the "Citation" column and confirm that a Bootstrap modal is triggered showing the correct data. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Modal looks much better. Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15327 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org