[Bug 15382] New: 245$a visibility constraints not respected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Bug ID: 15382 Summary: 245$a visibility constraints not respected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org The template file for opac-MARCdetail.pl uses a bibliotitle parameter, which is set regardless of the 'advanced constraints' settings of 245$a (which is linked to biblio.title see GetMarcFromKohaField). This patch will correct opac-MARCdetail.pl accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |mtompset@hotmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11592 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- This is related to 11592, but not dependent on it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|245$a visibility |245$a visibility |constraints not respected |constraints not respected | |in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Blocks| |11592 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Okay, it is a tiny piece of the larger puzzle. It blocks 11592, but it can be pushed by itself. :) Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 [Bug 11592] opac detail scripts do not respect MARC tag visibility -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 45708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45708&action=edit Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl This tiny change determines if the bibliotitle should be set or not in accordance with the 'Advanced constraints' visiblity setting for OPAC. TEST PLAN --------- 1) Find a record detail in OPAC 2) Click 'MARC view' -- 245$a should be visible. 3) In a new tab, log into the staff client 4) Click 'Koha administration' 5) Click 'MARC bibliographic framework' 6) Click 'MARC structure' for the framework of the record displayed in OPAC. 7) Search for tag: 245, and click 'Search' 8) Click 'Subfields' 9) Click 'Edit' beside the a subfield. 10) Click 'Advanced constraints' 11) Uncheck 'OPAC' 12) Click 'Save changes' 13) In the OPAC tab, refresh -- 245$a (Title) will still be visible! 14) Apply this patch 15) In the OPAC tab, refresh -- 245$a (Title) will be hidden. 16) In the staff client, navigate back to 'Advanced constraints' and check 'OPAC' 17) Click 'Save changes' 18) In the OPAC tab, refresh -- 245$a (Title) will be visible again. 19) Run koha qa tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45708|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45714&action=edit Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl This tiny change determines if the bibliotitle should be set or not in accordance with the 'Advanced constraints' visiblity setting for OPAC. TEST PLAN --------- 1) Find a record detail in OPAC 2) Click 'MARC view' -- 245$a should be visible. 3) In a new tab, log into the staff client 4) Click 'Koha administration' 5) Click 'MARC bibliographic framework' 6) Click 'MARC structure' for the framework of the record displayed in OPAC. 7) Search for tag: 245, and click 'Search' 8) Click 'Subfields' 9) Click 'Edit' beside the a subfield. 10) Click 'Advanced constraints' 11) Uncheck 'OPAC' 12) Click 'Save changes' 13) In the OPAC tab, refresh -- 245$a (Title) will still be visible! 14) Apply this patch 15) In the OPAC tab, refresh -- 245$a (Title) will be hidden. 16) In the staff client, navigate back to 'Advanced constraints' and check 'OPAC' 17) Click 'Save changes' 18) In the OPAC tab, refresh -- 245$a (Title) will be visible again. 19) Run koha qa tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45714|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45853&action=edit Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl This tiny change determines if the bibliotitle should be set or not in accordance with the 'Advanced constraints' visiblity setting for OPAC. TEST PLAN --------- 1) Find a record detail in OPAC 2) Click 'MARC view' -- 245$a should be visible. 3) In a new tab, log into the staff client 4) Click 'Koha administration' 5) Click 'MARC bibliographic framework' 6) Click 'MARC structure' for the framework of the record displayed in OPAC. 7) Search for tag: 245, and click 'Search' 8) Click 'Subfields' 9) Click 'Edit' beside the a subfield. 10) Click 'Advanced constraints' 11) Uncheck 'OPAC' 12) Click 'Save changes' 13) In the OPAC tab, refresh -- 245$a (Title) will still be visible! 14) Apply this patch 15) In the OPAC tab, refresh -- 245$a (Title) will be hidden. 16) In the staff client, navigate back to 'Advanced constraints' and check 'OPAC' 17) Click 'Save changes' 18) In the OPAC tab, refresh -- 245$a (Title) will be visible again. 19) Run koha qa tools Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master, thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15382 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org