https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Taking another look at this - I had been hoping to see some unit tests here by now :( 1) There are some changes that appear unrelated to the patch sets intent - maybe local changes that slipped in? To me it looks like they should be moved to a separate bug: - <span aria-hidden="true">x</span> + <span aria-hidden="true">×</span> 2) For any change to a .pm we require unit tests. 3) Being a really nit-picky librarian (and because I could not stand being told I had missed it) (not blocker) ('OPACAllowUserToChooseBranch','1','1','Allow the user to choose the branch they want to pickup their hold from','YesNo'), +('OPACAllowUserToChangeBranch','','Pending, In-Transit, Suspended','Allow users to change the library to pick up a hold for these statuses:','multiple'), Change should be before Choose :) 4) Table column has "pick up", but modal has "pickup" - what's correct? This is a fail for 2) mostly - others I would have fixed myself. Please come back with this patch set, it's would be a great addition. -- You are receiving this mail because: You are watching all bug changes.