[Bug 29216] New: Correct --where documentation in update_patrons_category.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Bug ID: 29216 Summary: Correct --where documentation in update_patrons_category.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Hi, This is absolutely very minor, but I was reading the in-code documentation for update_patrons_category.pl for the --where parameter and I think there is an error/typo. 133 =item B<--where $conditions> 134 135 Use this option to specify a condition built with columns from the borrowers table 136 137 e.g. 138 --where 'email IS NULL' 139 will update all patrons with no value for email 140 141 --where 'categorycode LIKE "%CHILD"' 142 will update all patrons with a category ending in CHILD. 143 144 --where 'categorycode LIKE RESIDENT%' 145 will update all patrons whose category does not begin with RESIDENT. I think this last example should be 144 --where 'categorycode NOT LIKE RESIDENT%' to match with the explanation below I may be wrong, though... I will submit a patch correcting this how I think it should be and I will let the experts verify it to make sure. :) Caroline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 126131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126131&action=edit Bug 29216: Correct --where documentation in update_patrons_category.pl This patch corrects one of the examples for the --where parameter in the update_patrons_category.pl script. To test: 1. Apply patch 2. In your favourite text editor, open misc/cronjobs/update_patrons_category.pl 3. Look for the documentation for the --where parameter (around line 133 or so) 4. Make sure the examples and their explanations make sense 5. Sign off :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126131|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126231&action=edit Bug 29216: Correct --where documentation in update_patrons_category.pl This patch corrects one of the examples for the --where parameter in the update_patrons_category.pl script. To test: 1. Apply patch 2. In your favourite text editor, open misc/cronjobs/update_patrons_category.pl 3. Look for the documentation for the --where parameter (around line 133 or so) 4. Make sure the examples and their explanations make sense 5. Sign off :) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Status|Signed Off |Failed QA --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- The two --where examples with categorycode in them don't make sense, you can only define one categorycode to the script with the --from parameter so those examples don't do anything useful and might make the user think it is possible to have wild card selection for the --from category. I think we should just remove those examples instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126231|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 126239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126239&action=edit Bug 29216: Correct --where documentation in update_patrons_category.pl This patch removes two misleading examples of the --where parameter documentation in update_patrons_category.pl To test: 1. Apply patch 2. In your favourite text editor, open misc/cronjobs/update_patrons_category.pl 3. Look for the documentation for the --where parameter (around line 133 or so) 4. Make sure the examples and their explanations make sense 5. Sign off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks David for signing off and Joonas for double checking. I removed the two examples completely. There is still the --where 'email IS NULL' example to illustrate this parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Caroline thanks! Unfortunately the new patch is based on the now obsoleted patch so it doesn't apply on top of master version. Could you do it on top of master version again and re-submit? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126239|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 126340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126340&action=edit Bug 29216: Correct --where documentation in update_patrons_category.pl This patch removes two misleading examples of the --where parameter documentation in update_patrons_category.pl To test: 1. Apply patch 2. In your favourite text editor, open misc/cronjobs/update_patrons_category.pl 3. Look for the documentation for the --where parameter (around line 133 or so) 4. Make sure the examples and their explanations make sense 5. Sign off :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Oops! Sorry about that! I don't fully understand how git works, so I make silly mistakes like that... I deleted everything and redid my patch (thankfully, it was just deleting a couple of lines!). Hopefully it will now work... :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126340|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 126350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126350&action=edit Bug 29216: Correct --where documentation in update_patrons_category.pl This patch removes two misleading examples of the --where parameter documentation in update_patrons_category.pl To test: 1. Apply patch 2. In your favourite text editor, open misc/cronjobs/update_patrons_category.pl 3. Look for the documentation for the --where parameter (around line 133 or so) 4. Make sure the examples and their explanations make sense 5. Sign off :) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126350|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126556&action=edit Bug 29216: Correct --where documentation in update_patrons_category.pl This patch removes two misleading examples of the --where parameter documentation in update_patrons_category.pl To test: 1. Apply patch 2. In your favourite text editor, open misc/cronjobs/update_patrons_category.pl 3. Look for the documentation for the --where parameter (around line 133 or so) 4. Make sure the examples and their explanations make sense 5. Sign off :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would have picked another good example instead of removing it. Not important anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126556|0 |1 is obsolete| | --- Comment #15 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- Created attachment 126815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126815&action=edit Bug 29216: Correct --where documentation in update_patrons_category.pl This patch removes two misleading examples of the --where parameter documentation in update_patrons_category.pl To test: 1. Apply patch 2. In your favourite text editor, open misc/cronjobs/update_patrons_category.pl 3. Look for the documentation for the --where parameter (around line 133 or so) 4. Make sure the examples and their explanations make sense 5. Sign off :) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- @Jérémy You reoploaded the same patch, did you mean to add a signoff? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 Jérémy Breuillard <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard@biblibre. | |com --- Comment #18 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #17)
@Jérémy You reoploaded the same patch, did you mean to add a signoff?
Yes, sorry for the mistake -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29216 --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks for the additional check, it helps :) The patch has already been integrated in master and the stable branches so don't worry about adding the signoff. For your next signoff, you can check that the line "Signed-off-by YOUR_NAME" is there before attaching a patch by using `git log` or `git show` -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org