[Bug 10431] New: Spanish Zebra language definition file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Bug ID: 10431 Summary: Spanish Zebra language definition file Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pablo.bianchi@gmail.com CC: frederic@tamil.fr Created attachment 18763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18763&action=edit Spanish Zebra language definition file It seems we have available for 'en', 'fr', 'nb', 'ru', 'uk' for ZEBRA_LANGUAGE on /etc/koha/koha-sites.conf But with the attached sort-string-utf.chr Spanish Zebra language definition file this language could also be available. And like Galen says [1]:
In addition to creating a new directory under lang_defs, you would need to update zebra-biblios.cfg and/or zebra-biblios-dom.cfg and zebra-authorities.cfg/zebra-authorities-dom.cfg to point to the new directory and restart your Zebra server. For the purpose of making a patch, in addition to adding etc/zebradb/lang_defs/XXX, you should patch Makefile.PL so that the new languages are available as options to set ZEBRA_LANGUAGE during installation.
[1] http://lists.katipo.co.nz/public/koha/2013-January/035288.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Patch complexity|--- |Small patch Version|3.12 |master Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18843&action=edit Bug 10431 - Spanish Zebra character sorting file This patch provides a definition file for spanish (es) character sorting in Zebra. It is based on the ideas from Hugo Agud <hagud@orex.es> and Pablo Bianchi <pablo.bianchi@gmail.com>. Makefile.PL is fixed to notice the existence of the 'es' language. The docs for koha-create are touched too. To test: Tarball ======= - Go through the install process, choosing 'es' for the Zebra's language step - Koha should work as usual. - Running this should show the lang definition is properly set. $ grep -R "lang_defs/es" /etc/koha/* (stuff like zebradb/zebra-biblios-dom.cfg:profilePath:...etc/koha/zebra/lang_defs/es... should show) - This file should be present: /etc/koha/zebradb/lang_defs/es/sort-string-utf.chr Packages ======== - Build your own package, it shouldn't break the packaging - Try the new package, using koha-create to set an instance using --lang 'es' Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10447 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I thought of adding a followup for enabling 'ru' and 'uk' too, which already had their language definitions in place. I chose to fill a new bug for that, which depends on this one. Its bug 10447. Regards To+ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt@gmail.com --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Marking failed QA - when I applied the patch with git-bz, the character map file was in the ISO-8859-1 character encoding; it needs to use UTF-8. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18843|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 19136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19136&action=edit Bug 10431 - Spanish Zebra character sorting file This patch provides a definition file for spanish (es) character sorting in Zebra. It is based on the ideas from Hugo Agud <hagud@orex.es> and Pablo Bianchi <pablo.bianchi@gmail.com>. Makefile.PL is fixed to notice the existence of the 'es' language. The docs for koha-create are touched too. To test: Tarball ======= - Go through the install process, choosing 'es' for the Zebra's language step - Koha should work as usual. - Running this should show the lang definition is properly set. $ grep -R "lang_defs/es" /etc/koha/* (stuff like zebradb/zebra-biblios-dom.cfg:profilePath:...etc/koha/zebra/lang_defs/es... should show) - This file should be present: /etc/koha/zebradb/lang_defs/es/sort-string-utf.chr Packages ======== - Build your own package, it shouldn't break the packaging - Try the new package, using koha-create to set an instance using --lang 'es' Regards To+ Edit: original file was ISO-8859-1, fixed. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19136|0 |1 is obsolete| | --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 19144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19144&action=edit Bug 10431 - Spanish Zebra character sorting file This patch provides a definition file for Spanish (es) character sorting in Zebra. It is based on the ideas from Hugo Agud <hagud@orex.es> and Pablo Bianchi <pablo.bianchi@gmail.com>. Makefile.PL is fixed to notice the existence of the 'es' language. The docs for koha-create are touched too. To test: Tarball ======= - Go through the install process, choosing 'es' for the Zebra's language step - Koha should work as usual. - Running this should show the lang definition is properly set. $ grep -R "lang_defs/es" /etc/koha/* (stuff like zebradb/zebra-biblios-dom.cfg:profilePath:...etc/koha/zebra/lang_defs/es... should show) - This file should be present: /etc/koha/zebradb/lang_defs/es/sort-string-utf.chr Packages ======== - Build your own package, it shouldn't break the packaging - Try the new package, using koha-create to set an instance using --lang 'es' Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 19218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19218&action=edit Bug 10431 - Redundant mappings removed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- There were some chars I overlooked that ended up being redundant mappings. zerbaidx warns about them when run in verbose mode from rebuild_zebra.pl. Several chars were mapped into their "parent" ascii char, but also set an order in the lowercase and uppercase definitions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19144|0 |1 is obsolete| | CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19222&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19218|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|tomascohen@gmail.com |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19223&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19222|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19409&action=edit Bug 10431 - Spanish Zebra character sorting file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19223|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19410&action=edit Bug 10431 - Redundant mappings removed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Pablo for reporting! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org