http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- So I copied the necessary files to /usr/share/koha/intranet/cgi-bin/plugins/ to be able to test some more and I notice that the "Upload a plugin" link on the left hand side of plugins-home.pl is not showing, either when I am logged in as superlibrarian or as a "regular" user with all the plugin permissions. This might be caused by my ad hoc attempts to fix the previous problems, but it at least deserves another look when the other problems are fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- OK, so as I understand it, we'd need to: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) 4) I'm not sure what the deal is with the cgi-bin/plugins directory. What goes there? How is it generated in a normal installation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- Why is that not created by the makefile like everything else? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- One note, /plugins/ is where the plugin system lives ( plugins-home.pl, etc ) and /plugin/ is an Alias in the Apache config to the directory where installed plugins live ( var/lib/plugins ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some more comments after digging around some more: (In reply to comment #4)

OK, so as I understand it, we'd need to:

1) koha-create: fill in __PLUGINS_DIR__

And we probably want to have some standard location, so all we really need to fill in is the instancename.

2) leave the enable_plugins as off (at least for now)

Yeah, Jared seems very set on making sure plugins are not enabled by accident... ;-)

3) koha-create-dirs: create the directory, set permissions (writeable by the koha user)

An alternative approach could be to have a separate script like koha-plugins-enable that creates the dirs only when they are actually needed. But putting it in koha-create-dirs is probably a lot less work...

4) I'm not sure what the deal is with the cgi-bin/plugins directory. What goes there? How is it generated in a normal installation?s

As far as I can tell, the problem is that the new plugins/ dir we have in the repository is not mentioned in Makefile.PL. I wonder if this will result in the same problem Im seeing on a standard install? I got the paths slightly wrong. This is the URL from Plugins in the More menu, which gives me a 404: /cgi-bin/koha/plugins/plugins-home.pl As Kyle pointed out there is another problem too: 5) The Alias /plugin/ ... stuff is missing from the Apache configs installed by the packages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16791&action=edit [PASSED QA] Bug 9890 - Fix the new plugin system for package installs Create the plugins directory in the Makefile Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> One line change, all ok. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (14:58:28) jcamins: bug 9890 just needs one sign off or QA. (14:58:29) huginn: Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 normal, P5 - low, ---, koha-bugs, Needs Signoff , Fix the new plugin system for package installs (14:58:49) jcamins: I will QA it myself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 --- Comment #15 from Magnus Enger <magnus@enger.priv.no> --- (In reply to comment #14)

OK, so that patch solves the bit I was unsure of, so that leaves setting up the directories and the koha-conf, right?

Yea, and the Apache conf. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16791|0 |1 is obsolete| | --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18417&action=edit Bug 9890 - Fix koha-create and koha-create-dirs As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly fills __PLUGINS_DIR__ in every installed file. - koha-create-dirs now creates the relevant dir. - enable_plugins is set to 0 currently, no action required here. Regarding the apache configurations, I'm not sure what you mean. Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18417|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 18564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18564&action=edit Bug 9890 - Fix koha-create and koha-create-dirs As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly fills __PLUGINS_DIR__ in every installed file. - koha-create-dirs now creates the relevant dir. - enable_plugins is set to 0 currently, no action required here. Regarding the apache configurations, I'm not sure what you mean. Regards To+ Edit: got some minutes to test and re-check and found that the substitution didn't put the right data. Fixed Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18564|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18620&action=edit Bug 9890 - Fix koha-create and koha-create-dirs As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly fills __PLUGINS_DIR__ in every installed file. - koha-create-dirs now creates the relevant dir. - enable_plugins is set to 0 currently, no action required here. Regarding the apache configurations, I'm not sure what you mean. Regards To+ Edit: got some minutes to test and re-check and found that the substitution didn't put the right data. Fixed Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #23 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.