[Bug 27474] New: Improve link text to define a label printer profile if none defined and fix conditional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Bug ID: 27474 Summary: Improve link text to define a label printer profile if none defined and fix conditional Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org In Tools -> Label creator, ensure you have no printer profiles created. Go to add a new label template. In the dropdown next to Profile, a No Profile/NA option is selected. In the template koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-template.tt there is a message that is supposed to direct a person to create a new printer profile since there are none ('click here'), but this never shows because of the 'No Profile/NA' option. This should be patched so reword the click here message. "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. We should also fix the IF statement so that the message will show if there is only one profile in the profiles loop. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |26722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722 [Bug 26722] [Omnibus] Use descriptive link texts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amyking386@gmail.com Assignee|oleonard@myacpl.org |amyking386@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 --- Comment #1 from Amy King <amyking386@gmail.com> --- Created attachment 115470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115470&action=edit Bug 27474: improve link text when no avaliable printer profiles Test plab: 1. Go to tools, click on label creator. 2. Make sure you have some(1-2) printer profiles free to attach to a label template. You can do this by clicking on manage, printer profiles, if there is a blank space under the "Template name" header, then it is free to attach to a label template. 3. Click on add new label template. 4. Note how there is a drop down menu beside "Profile:", to select a printer profile. 5. Assign all of the avaliable printer profiles by making new label templates. 6. Now woth no avaliable printer profiles, click on add a new label template. 7. Note how there is a drop down menu beside "Profile:" only "No Profile/Na" is avaliable to select. 8. Apply patch. 9. Repeat steps 2-6. 10. Now note how there is a link to make a new printer profile, under the drop down menu next to "Profile:" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115470|0 |1 is obsolete| | --- Comment #2 from Amy King <amyking386@gmail.com> --- Created attachment 115472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115472&action=edit Bug 27474: improve link text when no avaliable printer profiles Test plan: 1. Go to tools, click on label creator. 2. Make sure you have some(1-2) printer profiles free to attach to a label template. You can do this by clicking on manage, printer profiles, if there is a blank space under the "Template name" header, then it is free to attach to a label template. 3. Click on add new label template. 4. Note how there is a drop down menu beside "Profile:", to select a printer profile. 5. Assign all of the avaliable printer profiles by making new label templates. 6. Now woth no avaliable printer profiles, click on add a new label template. 7. Note how there is a drop down menu beside "Profile:" only "No Profile/Na" is avaliable to select. 8. Apply patch. 9. Repeat steps 2-6. 10. Now note how there is a link to make a new printer profile, under the drop down menu next to "Profile:" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115472|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115593&action=edit Bug 27474: improve link text when no avaliable printer profiles Test plan: 1. Go to tools, click on label creator. 2. Make sure you have some(1-2) printer profiles free to attach to a label template. You can do this by clicking on manage, printer profiles, if there is a blank space under the "Template name" header, then it is free to attach to a label template. 3. Click on add new label template. 4. Note how there is a drop down menu beside "Profile:", to select a printer profile. 5. Assign all of the avaliable printer profiles by making new label templates. 6. Now woth no avaliable printer profiles, click on add a new label template. 7. Note how there is a drop down menu beside "Profile:" only "No Profile/Na" is avaliable to select. 8. Apply patch. 9. Repeat steps 2-6. 10. Now note how there is a link to make a new printer profile, under the drop down menu next to "Profile:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115593|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 115613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115613&action=edit Bug 27474: improve link text when no avaliable printer profiles Test plan: 1. Go to tools, click on label creator. 2. Make sure you have some(1-2) printer profiles free to attach to a label template. You can do this by clicking on manage, printer profiles, if there is a blank space under the "Template name" header, then it is free to attach to a label template. 3. Click on add new label template. 4. Note how there is a drop down menu beside "Profile:", to select a printer profile. 5. Assign all of the avaliable printer profiles by making new label templates. 6. Now woth no avaliable printer profiles, click on add a new label template. 7. Note how there is a drop down menu beside "Profile:" only "No Profile/Na" is avaliable to select. 8. Apply patch. 9. Repeat steps 2-6. 10. Now note how there is a link to make a new printer profile, under the drop down menu next to "Profile:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115613|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115693&action=edit Bug 27474: Improve link text when no avaliable printer profiles Test plan: 1. Go to tools, click on label creator. 2. Make sure you have some(1-2) printer profiles free to attach to a label template. You can do this by clicking on manage, printer profiles, if there is a blank space under the "Template name" header, then it is free to attach to a label template. 3. Click on add new label template. 4. Note how there is a drop down menu beside "Profile:", to select a printer profile. 5. Assign all of the avaliable printer profiles by making new label templates. 6. Now woth no avaliable printer profiles, click on add a new label template. 7. Note how there is a drop down menu beside "Profile:" only "No Profile/Na" is avaliable to select. 8. Apply patch. 9. Repeat steps 2-6. 10. Now note how there is a link to make a new printer profile, under the drop down menu next to "Profile:" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27474 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org