[Bug 27472] New: Improve link text when successfully merging bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Bug ID: 27472 Summary: Improve link text when successfully merging bibliographic records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt: <p>The merge was successful. <a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% ref_biblionumber | uri %]">Click here to see the merged record.</a></p> "Here" should not be used as a link text as it doesn't contain any helpful information for people scanning the page for information and also is a problem for blind users using screen readers jumping from link to link on a page. To reproduce: 1. have or create two bibliographic records 2. in your terminal run sudo koha-rebuild-zebra -f -b -v kohadev 3. do a catalog search that will return both records in the results 4. select the checkboxes for both records 5. click edit->merge and continue the process of merging two records 6. notice the 'click here' message after successfully merging -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26722 Keywords| |Academy Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26722 [Bug 26722] [Omnibus] Use descriptive link texts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amyking386@gmail.com Assignee|oleonard@myacpl.org |amyking386@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 --- Comment #1 from Amy King <amyking386@gmail.com> --- Created attachment 115389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115389&action=edit Bug 27472: Changed link text from "click here" to "click this sentence". Test plan: 1. Complete the steps above, specially noting the last step. 2. Apply patch 3. Complete the steps above, but now notice how the link says "Click this sentence..." after merging. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115389|0 |1 is obsolete| | --- Comment #2 from Amy King <amyking386@gmail.com> --- Created attachment 115391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115391&action=edit Bug 27472: Link text change so is more helpful. Test Plan: 1. Complete the steps to reproduce above, specially noting the last step 2. Apply the patch 3. Complete step 1 again, but now notice how the link says "This sentence is the link to ..." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- "This sentence is the link to see the merged record." doesn't make sense to me, it sounds like placeholder text. How about "View the merged record" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Amy King <amyking386@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115391|0 |1 is obsolete| | --- Comment #4 from Amy King <amyking386@gmail.com> --- Created attachment 115453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115453&action=edit Bug 27472: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115453|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115542&action=edit Bug 27472: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115542|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115562&action=edit Bug 27472: changed link text Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115562|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115692&action=edit Bug 27472: Improve link text (merge.tt) Test plan: 1. Complete the steps above to reproduce, specially noting the last step. 2. Apply patch 3. Complete step 1 again, but now notice how the link says "View the merged record" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27472 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org