[Bug 14528] New: Viewing lists fails silently when not having correct permisison
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Bug ID: 14528 Summary: Viewing lists fails silently when not having correct permisison Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: koha@jsense.co.uk QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Whilst testing the list permissions I found a problem. I have an account with staff client access and I went to the Lists module. You immediately get "Processing..." whilst an Ajax request takes place but then nothing else happens. I can debug to see that the search request failed to to not having permission. My primary concern is that I don't think any Ajax service call should fail silently like this - the user need to know it has failed. In this case the permission needed was "borrowers" - see /svc/virtualshelves/search. That doesn't make any sense to me - why would I need to have permission to "Add or modify patrons" when I just want to see Lists? Lastly, there may be some connection to issue 6960 but fixing that would only hide the primary problem described above. To reproduce: 1. Set up a user without "borrowers" permission 2. Go to /cgi-bin/koha/virtualshelves/shelves.pl 3. Note that it says "Processing..." and never completes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|minor |normal Version|3.20 |unspecified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40995&action=edit Bug 14528: Inconsistency in permissions check when listing shelves The svc script needed borrowers when the shelves.pl needed catalogue. There is no sense to have different permissions here. Test plan: 1/ Remove the borrowers permission to a user 2/ Use this user to log in 3/ Go on the shelf list 4/ Without this patch, you should get an endless "Processing..." which is fixed if you apply it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40995|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40996&action=edit Bug 14528: Inconsistency in permissions check when listing shelves The svc script needed borrowers when the shelves.pl needed catalogue. There is no sense to have different permissions here. Test plan: 1/ Remove the borrowers permission to a user 2/ Use this user to log in 3/ Go on the shelf list 4/ Without this patch, you should get an endless "Processing..." which is fixed if you apply it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40996|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 41090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41090&action=edit Bug 14528: Inconsistency in permissions check when listing shelves The svc script needed borrowers when the shelves.pl needed catalogue. There is no sense to have different permissions here. Test plan: 1/ Remove the borrowers permission to a user 2/ Use this user to log in 3/ Go on the shelf list 4/ Without this patch, you should get an endless "Processing..." which is fixed if you apply it. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41090|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43083&action=edit [PASSED QA] Bug 14528: Inconsistency in permissions check when listing shelves The svc script needed borrowers when the shelves.pl needed catalogue. There is no sense to have different permissions here. Test plan: 1/ Remove the borrowers permission to a user 2/ Use this user to log in 3/ Go on the shelf list 4/ Without this patch, you should get an endless "Processing..." which is fixed if you apply it. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks onathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org