http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43095&action=edit Bug 14950 - Remove C4::Dates from tools/batchMod.pl This patch removes C4::Dates from tools/batchMod.pl To test: - In MARC bibliographic Default framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Got to Home > Tools > Batch item modification - Enter one ore more barcodes you want to modify - Check checkbox 'Populate fields with defautl values from defautl framework - Click 'Continue' - Verify on the follwing screen that the field in Edit form is populated as appropriate (in our example 'x - Non public note') - Clcik 'Save' - Verify that the items are updated as appropriate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com --- Comment #2 from Joonas Kylmälä <j.kylmala@gmail.com> --- What is the comment "FIXME: iso dates don't have commas!" about? split ',', $today_iso doesn't work? Or is the comment about that Koha uses a comma instead of -? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #4 from Joonas Kylmälä <j.kylmala@gmail.com> --- (In reply to Marc Véron from comment #3)

(In reply to Joonas Kylmälä from comment #2)

...

What is the comment "FIXME: iso dates don't have commas!" about? split ',', $today_iso doesn't work? Or is the comment about that Koha uses a comma instead of -?

I do not really know what the author of tis comment intended. But the comment now is obsolete because the code changed to get the values to replace YYYY, MM and DD

Yes, it's obsolete now. I was reading the git diff in the wrong way and thought that you put the comment there ! :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43095|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä <j.kylmala@gmail.com> --- Created attachment 43106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43106&action=edit Bug 14950 - Remove C4::Dates from tools/batchMod.pl Test plan worked. Code looks good. This patch removes C4::Dates from tools/batchMod.pl To test: - In MARC bibliographic Default framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Got to Home > Tools > Batch item modification - Enter one ore more barcodes you want to modify - Check checkbox 'Populate fields with defautl values from defautl framework - Click 'Continue' - Verify on the follwing screen that the field in Edit form is populated as appropriate (in our example 'x - Non public note') - Clcik 'Save' - Verify that the items are updated as appropriate Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43106|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43155&action=edit Bug 14950 - Assign default value for YYYY, MM and DD [was Remove C4::Dates from tools/batchMod.pl] This patch replace the YYYY, MM and DD if defined in the default values. This patch also removes C4::Dates from tools/batchMod.pl To test: - In MARC bibliographic Default framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Got to Home > Tools > Batch item modification - Enter one ore more barcodes you want to modify - Check checkbox 'Populate fields with defautl values from defautl framework - Click 'Continue' - Verify on the follwing screen that the field in Edit form is populated as appropriate (in our example 'x - Non public note') - Click 'Save' - Verify that the items are updated as appropriate Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended commit message: This is a bug fix and can be backported. The YYYY, MM and DD were not replaced correctly before this patch. I got Year:2015-10-06 Month: Day: now I correctly get Year: 2015 Month: 10 Day: 06 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org Summary|Remove C4::Dates from |A date is not correctly |tools/batchMod.pl |filled in default values | |from batch mod [was Remove | |C4::Dates from | |tools/batchMod.pl] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14922 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tomas, could you please consider this last patch for master please? On bug 14922, I caught this problem and would prefer to fix it here as the patches could be backported on stable branches (14922 is an enh). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.