https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Katariina Pohto <trainee@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trainee@koha-suomi.fi --- Comment #2 from Katariina Pohto <trainee@koha-suomi.fi> --- The process can be repeated like this: 1. Select several biblios and choose Place hold 2. Choose a patron 3. Select a pickup location for all biblios and deselect one of the checkmarks 4. Place holds and note that even the deselected holds was placed. I looked into the code and noticed that the biblionumbers passed on to placerequest.pl come from hidden input fields that have no connection to the checkmark fields. This also means that the form validation will not care about invalid information on the unchecked biblios, which results in errors at least when unchecked biblio doesn't have a pickup location set: 1. Select several biblios and click Place hold 2. Choose a patron 3. Deselect one of the biblio checkmarks and leave the pickup location empty for that biblio. 4. Place holds and end up on an error page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 --- Comment #3 from Katariina Pohto <trainee@koha-suomi.fi> --- Created attachment 166780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166780&action=edit Bug 35771: Unselecting titles when making multi-hold does not have any effect This patch moves the holdable_bibs id and value to the checkmark input. It doesn't do the same for the club multihold (which probably should be added), and doesn't change the <input name="biblionumber"> field which lists the biblios that end up on the URL query. It might also be beneficial to change the placerequest.pl's redirect to request.pl to use the holdable_bibs list instead of the biblionumber list, so the unselected biblio wouldn't appear on request.pl page after the holds are placed Test plan: 1. Select several biblios and choose Place hold 2. Choose a patron 3. Select a pickup location for all biblios and unselect one of the checkmarks 4. Place holds and note that even the deselected holds was placed. 5. Repeat steps 1-2. 6. Leave pickup locations empty and try to place the holds. 7. Note alert: "Please make sure all selected titles have a pickup location set" 8. Uncheck one of the biblios and add pickup locations to the checked biblios. 9. Try to place the holds and note that there is no alert, and you get an error 500. 10. Apply patch. 11. Repeat steps 1,2,8 and place holds. 12. Note that there is no error 500, and while all the biblios are shown on page, only the checked biblios have a new hold placed on them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- With this patch applied I cannot place multi-hold's at all. I think we should also fix the problem of multiple ID's ( #holdable_bibs ) on the same page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Katariina Pohto <trainee@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166780|0 |1 is obsolete| | --- Comment #6 from Katariina Pohto <trainee@koha-suomi.fi> --- Created attachment 166977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166977&action=edit Bug 35771: Unselecting titles when making multi-hold I had dropped out the name attribute, which might be the reason for the patch failing. New patch with the same steps as previously. Someone else should pick up on this and check the club multi-hold too, and get rid of the multiple IDs, I wont be able to work on this further. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I've signed off as everything now seems to work as per the test plan. For items that are listed, but where the holds are not placed (where an item was unselected), the message shown is "There are no holds on this title.". Ideally, this should say something "No hold placed for this title", or something similar. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |katariina.pohto@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167060|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171259&action=edit Bug 35771: Unselecting titles when making multi-hold When placing a hold on multiple biblios Place Holds page (request.pl) has checkboxes for unselecting some of the listed biblios. Removing the checkmark does not actually unselect the biblio. Clicking the Place holds button will place a hold for all the biblios on page that can be reserved. If unchecked biblio does not have a pickup location, it will get past form validation and cause an error. Test plan: 1. Select several biblios and choose Place hold 2. Choose a patron 3. Select a pickup location for all biblios and unselect one of the checkmarks 4. Place holds and note that even the deselected holds was placed. 5. Repeat steps 1-2. 6. Leave pickup locations empty and try to place the holds. 7. Note alert: "Please make sure all selected titles have a pickup location set" 8. Uncheck one of the biblios and add pickup locations to the checked biblios. 9. Try to place the holds and note that there is no alert, and you get an error 500. 10. Apply patch. 11. Repeat steps 1,2,8 and place holds. 12. Note that there is no error 500, and while all the biblios are shown on page, only the checked biblios have a new hold placed on them. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #13)

Pushed to 23.11.x for 23.11.11

Hey Frido, are you sure you applied this correctly? I can't get multi-hold to work in 23.11.11 for the staff interface and when I compare the patches here... it looks like you applied changes to lines 341 and 501, but the patches for main were for lines 1062 and 1124 When I visit http://localhost:8091/cgi-bin/koha/reserve/request.pl?biblionumber=114&biblionumber=29&multi_hold=1&borrowernumber=51 I see that there's no "holdable_bibs" name applied to the checkboxes. request.tt is a bit of a mess, so I'm trying to puzzle it all out... I can't really work out everything but it looks like line 947 is the one that needs a fix... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.