[Bug 37385] New: Transfer not triggered automatically when cancelling a hold by checking item in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Bug ID: 37385 Summary: Transfer not triggered automatically when cancelling a hold by checking item in Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: heather@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When I check in an item to cancel a waiting hold on an item from another library, the transfer message doesn't pop up to return item to its home library after the hold is cancelled. In previous versions, the steps would be: -Find item with a waiting hold, and check it in -On the popup notifying me of the waiting hold, select 'Cancel hold' -A second popup appears notifying me of the need to transfer the item to its home library, which I could confirm or cancel. The second popup is no longer appearing. I have to check the item in a second time to trigger the transfer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169132&action=edit Bug 37385: Transfer not triggered automatically when cancelling a hold by checking item in (edit) Upadates for CSRF are inadvertently stopping AddReturn from being trigger when a hold is canceled. This is necessary to generate the transfer back to the originating library. Test Plan: 1) Find item with a waiting hold, and check it in 2) In the popup notifying me of the waiting hold, select 'Cancel hold' 3) Note no second popup appears notifying you of the need to transfer the item to its home library 4) Apply this patch 5) Restart all the things! 6) Repeat steps 1-2 7) Second popup appears! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version|24.05 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169132|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169134&action=edit Bug 37385: Transfer not triggered automatically when cancelling a hold by checking item in (edit) Upadates for CSRF are inadvertently stopping AddReturn from being trigger when a hold is canceled. This is necessary to generate the transfer back to the originating library. Test Plan: 1) Find item with a waiting hold, and check it in 2) In the popup notifying me of the waiting hold, select 'Cancel hold' 3) Note no second popup appears notifying you of the need to transfer the item to its home library 4) Apply this patch 5) Restart all the things! 6) Repeat steps 1-2 7) Second popup appears! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Transfer not triggered |Transfer/next hold modals |automatically when |not triggered automatically |cancelling a hold by |when cancelling a hold by |checking item in |checking item in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This fix also fixes a similar issue reported in Bug 37347. I have changed this bug title to reflect that and will resolve 37347 as a duplicate of this one. Thank you, Kyle! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrown@bywatersolutions.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 37347 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169161&action=edit Bug 37385: Fix Transfer not triggering automatically when cancelling a hold by checking in an item Upadates for CSRF are inadvertently stopping AddReturn from being trigger when a hold is canceled. This is necessary to generate the transfer back to the originating library. Test Plan: 1) Find item with a waiting hold, and check it in 2) In the popup notifying me of the waiting hold, select 'Cancel hold' 3) Note no second popup appears notifying you of the need to transfer the item to its home library 4) Apply this patch 5) Restart all the things! 6) Repeat steps 1-2 7) Second popup appears! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169134|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169161|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 169166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169166&action=edit Bug 37385: Fix Transfer not triggering automatically when cancelling a hold by checking in an item Upadates for CSRF are inadvertently stopping AddReturn from being trigger when a hold is canceled. This is necessary to generate the transfer back to the originating library. Test Plan: 1) Find item with a waiting hold, and check it in 2) In the popup notifying me of the waiting hold, select 'Cancel hold' 3) Note no second popup appears notifying you of the need to transfer the item to its home library 4) Apply this patch 5) Restart all the things! 6) Repeat steps 1-2 7) Second popup appears! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- The patch makes sense and fixes the regression, and QA tool passes. Passing QA As a side note, I don't love that we call AddReturn again to initiate the next action after canceling a hold. At the very least, in inflates the local use count if RecordLocalUseOnReturn is on - not sure if it introduces other side effects in that situation as well. That's a separate issue that has been there for a while, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.02 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36192 Text to go in the| |This fixes an issue when release notes| |checking in an item to | |cancel a waiting hold - if | |a transfer to the | |originating library is | |required, the pop-up window | |notifying that a transfer | |is required was not | |automatically generated. | |(This is related to the | |CSRF changes added in Koha | |24.05 to improve form | |security.) CC| |david@davidnind.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Full CSRF not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37385 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org