[Bug 6766] New: Template variable scope errors in holds template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 Bug #: 6766 Summary: Template variable scope errors in holds template Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org Blocks: 5917 Created attachment 5103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5103 Each table of existing holds should show a title I've found two template variable scope errors in request.tt: One prevents the display of titles when the user is placing holds on multiple items. The other prevents the display of the patron information when there is a error placing a hold. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-08-23 16:15:20 UTC --- Created attachment 5104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5104 No patron name shows in error message Error should read "[Patron name] already has a hold on this item" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-08-23 16:20:05 UTC --- Created attachment 5105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5105 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-08-23 16:21:14 UTC --- Created attachment 5106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5106 Multiple holds after correction -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-08-23 16:22:01 UTC --- Created attachment 5107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5107 After correction, patron name appears in error message -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Needs Signoff |Passed QA --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-20 19:16:28 UTC --- Going to give this one a double-jump: please consider this my sign off, as well as the passing of the QA. Template only change, T:T scope fix, easy to read, documented VERY well with screen shots. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-20 21:40:58 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org