[Bug 5234] New: Remove unused CSS files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Summary: Remove unused CSS files Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: henridamien@koha-fr.org Estimated Hours: 0.0 These CSS files look like they're a relic of pre-3.0 days: intranet-print.css intranet.css intranet2.css intranet2popup.css This one hasn't been touched sine 2007: staff-global2.css ...Is it used by anyone? What about blue.css? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-02-09 14:07:22 UTC --- Created attachment 3111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3111 Proposed fix Patch leaves blue.css since some are still using it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Patch Status|Needs Signoff |Signed Off --- Comment #2 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-05 10:34:18 UTC --- This bug is mentioned in: Fix for Bug 5234 - Remove unused CSS files http://lists.koha-community.org/pipermail/koha-patches/2011-February/013799.... --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2011-04-07 13:36:46 UTC --- The patch removes the CSS files, and I can see no ill effects in the staff client. Grepping through all Koha files for the file names of the CSS files does not show them being used anywhere. Signing off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-04-08 22:23:48 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_4 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Signed Off --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-08-22 13:49:38 UTC --- It doesn't look like this patch was actually pushed. The files are still there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-22 20:37:09 UTC --- It was pushed, it is in master commit id 8464104fb299d1b1d707c0a083a04dce7c108953 http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=8464104fb299d1b1... Maybe it wasn't cherry-picked to 3.4? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Signed Off --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-09-13 15:01:23 UTC --- Ian pointed out to me on IRC that it looks like the removed files came back when we converted to T:T -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-13 20:52:13 UTC --- Reapplied and pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org