[Bug 34133] New: ILL table should be sorted by request id descending by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Bug ID: 34133 Summary: ILL table should be sorted by request id descending by default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com CC: pedro.amorim@ptfs-europe.com The table saves state, so a user can choose their own. The default should be newest requests first if a user does not set something -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152751&action=edit Bug 34133: Set default sort on first column (ID) desc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no Status|Needs Signoff |Failed QA --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- I applied the patch, restarted all the things, opened the main ILL page in an "incognito" window. When I look at the JS file the change has been applied, but the table still shows the lowest numbers at the top. Could I be missing something? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 152848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152848&action=edit Lowest numbers at the top -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Should this actually be sorting on the placed on date as a posed to ID? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Test plan: Before applying patch: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by ASC (lowest ID first) * Close incognito Apply patch, then: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by DESC (highest ID first) Did the test plan myself on both Google Chrome and Firefox. Can you please give it another go, Magnus? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152751|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 152886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152886&action=edit Bug 34133: Set default sort on first column (ID) desc Test plan: Before applying patch: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by ASC (lowest ID first) * Close incognito Apply patch, then: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by DESC (highest ID first) Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan from Bugzilla, and added it above. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152848|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- (In reply to Martin Renvoize from comment #4)
Should this actually be sorting on the placed on date as a posed to ID?
Would that make a difference in practice? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hey guys any chance for a PQA here? Something that needs improving? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152886|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 153541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153541&action=edit Bug 34133: Set default sort on first column (ID) desc Test plan: Before applying patch: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by ASC (lowest ID first) * Close incognito Apply patch, then: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by DESC (highest ID first) Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan from Bugzilla, and added it above. Works as advertised. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org