[Bug 34181] New: Batch Patron Modification Tool missing checkboxes to clear field values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Bug ID: 34181 Summary: Batch Patron Modification Tool missing checkboxes to clear field values Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: catrina@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 152920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152920&action=edit 22.05 Batch Patron Modification Tool with Checkboxes When using the batch patron modification tool in 22.05, you could select one of the boxes to the right of the field to clear the value. The instructions for this feature are in 22.11, but the checkboxes and functionality is missing. See attached screenshots for examples. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org --- Comment #1 from AspenCat Team <aspencatteam@clicweb.org> --- This is something we use fairly regularly and without it, it would require a much more time consuming overlay with a patron file. In some cases we would have too many patrons to go that route without having to bother ByWater with something that used to take a couple of minutes. - Bob -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Jennifer Marlatt <jennifer.marlatt@coronaca.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jennifer.marlatt@coronaca.g | |ov --- Comment #2 from Jennifer Marlatt <jennifer.marlatt@coronaca.gov> --- We use this feature at least once a week. I have a workaround in place, but takes significantly more time to complete what was once a quick and simple task. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The checkboxes are still there, but they are set to 'display:none' in the source code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch Patron Modification |Batch patron modification |Tool missing checkboxes to |tool missing checkboxes to |clear field values |clear field values Version|22.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A git bisect points to: Bug 32257 - Label for patron attributes misaligned on patron batch mod -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32257 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32257 [Bug 32257] Label for patron attributes misaligned on patron batch mod -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153521&action=edit Bug 34181: Fix jQuery selector to make delete checkboxes reappear Bug 32257 changed the page structure slightly to fix a display issue with the labels. This resulted in a broken selector in the function for displaying the checkboxes for deleting/emptying a certain patron field. To test: * Go to Tools > Batch patron modifications * Enter some cardnumbers or borrowernumbers * On the batch patron edit form, verify that the checkboxes behind each input field are missing * Apply patch * Verify the checkboxes reappeared * Verify that for mandatory fields the checkbox is locked * Make some batch edits and verify the checkboxes work as intended -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153521|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 153558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153558&action=edit Bug 34181: Fix jQuery selector to make delete checkboxes reappear Bug 32257 changed the page structure slightly to fix a display issue with the labels. This resulted in a broken selector in the function for displaying the checkboxes for deleting/emptying a certain patron field. To test: * Go to Tools > Batch patron modifications * Enter some cardnumbers or borrowernumbers * On the batch patron edit form, verify that the checkboxes behind each input field are missing * Apply patch * Verify the checkboxes reappeared * Verify that for mandatory fields the checkbox is locked * Make some batch edits and verify the checkboxes work as intended Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com Status|Needs Signoff |Signed Off --- Comment #7 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- Worked as expected! Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks, Lisette :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153558|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153662&action=edit Bug 34181: Fix jQuery selector to make delete checkboxes reappear Bug 32257 changed the page structure slightly to fix a display issue with the labels. This resulted in a broken selector in the function for displaying the checkboxes for deleting/emptying a certain patron field. To test: * Go to Tools > Batch patron modifications * Enter some cardnumbers or borrowernumbers * On the batch patron edit form, verify that the checkboxes behind each input field are missing * Apply patch * Verify the checkboxes reappeared * Verify that for mandatory fields the checkbox is locked * Make some batch edits and verify the checkboxes work as intended Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working as described.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.2 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.2 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org