[Bug 35413] New: Terminology: Manage issues (issue_manage)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Bug ID: 35413 Summary: Terminology: Manage issues (issue_manage) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org It would be clearer to change the description to: Manage vendor issues (issue_manage) The problem here is that issues can already be different things. In the past it meant checkouts, now most of the time it means serial issues. Having the standalone string is hard to translate and easy to confuse. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159303&action=edit Bug 35413: Terminology: Manage issues (issue_manage) This patch updates several files which use the term "issues" without context, changing them to "Vendor issues." Unchanged is the vendor issues page template, vendor_issues.tt, which is updated in Bug 35417. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - You should see a "Vendor issues" link in the sidebar. - Go to Patrons and search for a patron. View the patron's details. - Click More -> Set permissions. - Under Acquisitions management you should see "Manage vendor issues (issue_manage)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159303|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159319&action=edit Bug 35413: Terminology: Manage issues (issue_manage) This patch updates several files which use the term "issues" without context, changing them to "Vendor issues." Unchanged is the vendor issues page template, vendor_issues.tt, which is updated in Bug 35417. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - You should see a "Vendor issues" link in the sidebar. - Go to Patrons and search for a patron. View the patron's details. - Click More -> Set permissions. - Under Acquisitions management you should see "Manage vendor issues (issue_manage)" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35417 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: Manage issues |Terminology: differentiate |(issue_manage) |issues for vendor issues | |and serials --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for fixing the navigation! I ran into this today as it's the same string for serials and vendor issues currently. This will help a lot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Shouldn't there be a database migration for existing installs? Because they will still have the old description: select * from permissions where code = 'issue_manage'; | module_bit | code | description | | 11 | issue_manage | Manage issues | Or maybe it doesn't matter because where is permissions.description used anyway? The test plan seems to looks in the right places and they don't use permissions.description. Otherwise, all looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159319|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159964&action=edit Bug 35413: Terminology: Manage issues (issue_manage) This patch updates several files which use the term "issues" without context, changing them to "Vendor issues." Unchanged is the vendor issues page template, vendor_issues.tt, which is updated in Bug 35417. To test, apply the patch and go to Acquisitions. - Search for a vendor and view the details. - You should see a "Vendor issues" link in the sidebar. - Go to Patrons and search for a patron. View the patron's details. - Click More -> Set permissions. - Under Acquisitions management you should see "Manage vendor issues (issue_manage)" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159965&action=edit Bug 35413: DB update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Keywords|Academy | CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #4)
Shouldn't there be a database migration for existing installs? Because they will still have the old description:
Done. I don't think it is really an issue (cuack) but until we remove the unused column, we should always keep updated DB similar to fresh installs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org