[Bug 35405] New: MarcAuthorities: Use of uninitialized value $tag in hash element at MARC/Record.pm line 202.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Bug ID: 35405 Summary: MarcAuthorities: Use of uninitialized value $tag in hash element at MARC/Record.pm line 202. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org When calling SearchAuthorities, there can be a lot of noise from MARC::Record. For each hit: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 159274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159274&action=edit Bug 35405: Remove noise from MARC::Record in SearchAuthorities We are calling ->field with an undef parameter. MARC::Record does not like that and says: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. For now, a fix at our side. Test plan: Run SearchAuthorities without passing an authtypecode. Without this patch, it results in a warning per hit. With this patch, the noise should be gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159274|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159322&action=edit Bug 35405: Remove noise from MARC::Record in SearchAuthorities We are calling ->field with an undef parameter. MARC::Record does not like that and says: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. For now, a fix at our side. Test plan: Run SearchAuthorities without passing an authtypecode. Without this patch, it results in a warning per hit. With this patch, the noise should be gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Go to Authorities. 2. Using the search in the header bar, click on the arrow to perform a search. 3. Note that the warning "Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202." appears several times in the /var/log/koha/kohadev/plack-intranet-error.log file. 4. Perform another search, except change the Authority type search from "Default" to "Corporate Name" (using the little selector before the arrow). 5. Note that the warning message in step 3 is not recorded in the log file. 6. Apply the patch and restart_all 7. Repeat steps 2-5 - the warning in step 3 no longer appears. Additional note: this warning message appears in the log file once for each search (whether or not the authority type is selected) "[WARN] Use of uninitialized value $q2 in concatenation (.) or string at /kohadevbox/koha/C4/AuthoritiesMarc.pm line 230.". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159322|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159948&action=edit Bug 35405: Remove noise from MARC::Record in SearchAuthorities We are calling ->field with an undef parameter. MARC::Record does not like that and says: Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202. For now, a fix at our side. Test plan: Run SearchAuthorities without passing an authtypecode. Without this patch, it results in a warning per hit. With this patch, the noise should be gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35405 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org