http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10692 Assignee|gmcharlt@gmail.com |kenza.zaki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 --- Comment #1 from kenza <kenza.zaki@biblibre.com> --- Created attachment 20160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20160&action=edit Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- I cant get this to apply, even after apply 10692 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from kenza <kenza.zaki@biblibre.com> --- (In reply to Chris Cormack from comment #2)

I cant get this to apply, even after apply 10692

Sorry i forgot to mention it, but this patch also needs to apply 10681. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20616|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20648&action=edit Bug 10698: DeleteTransfer in C4::Circulation.pm needs return value This patch adds return values to DeleteTransfer: Undef if no parameters are given 1 if a Transfer is deleted 0E0 if a wrong parameter is given It also fixes some unit tests in t/db_dependent/Circulation_transfers.t To test: prove t/db_dependent/Circulation_transfers.t t/db_dependent/Circulation_transfers.t .. ok All tests successful. Files=1, Tests=14, 20 wallclock secs ( 0.03 usr 0.00 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied 10681 and 10692 before 10698 Run prove t/db_dependent/Circulation_transfers.t without errors No koha-qa errors on all 3 patches Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.