[Bug 10711] New: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bug ID: 10711 Summary: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kenza.zaki@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kenza.zaki@biblibre.com Depends on| |10681, 10710 Assignee|gmcharlt@gmail.com |kenza.zaki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 --- Comment #1 from kenza <kenza.zaki@biblibre.com> --- Created attachment 20269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20269&action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20269|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20617&action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: applied 10681 and 10710 before 10711 prove t/db_dependent/Circulation_OfflineOperation.t run without errors koha-qa reports only 2 tabulations, fixed in a follow-up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20618&action=edit Bug 10711: (follow-up) removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20617|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20649&action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth->fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: applied 10681 and 10710 before 10711 prove t/db_dependent/Circulation_OfflineOperation.t run without errors koha-qa reports only 2 tabulations, fixed in a follow-up Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20618|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20650&action=edit Bug 10711: (follow-up) removing tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org