https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38482 [Bug 38482] Disable save state for items tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174797&action=edit Bug 38485: Take user's previous change into consideration for holdings tables col vis A lot happened, hard to summarize everything. Basically at this point, we have (among other things): * fixed bug 38118 (but reintroduced it with bug 36640) * fixed bug 38436 (the original report was that the is_hidden setting was no longer taken into effect on the holdings tables) Here we are trying to deal with making user's previous changes persistent across the pagination and col vis changes. Test plan: Confirm that hiding checkouts in settings hide the columns Confirm that showing checkouts then change page (*pagination*, so you need more than 20 items) and confirm that the columns are still the same Add a callnumber for an item from page 2 and confirm that the column is hidden on page 1 and shown on page 2 Hide callnumber from the settings and confirm that the column is hidden on pages 1 and 2 Show callnumber from the holdings page and confirm that the column is displayed on page 2, go page 1: hidden, go back page 2: displayed. And certainly way more other things to test, just confirm that the behaviours with this patch are consistent with what a end user would expect. Note for QA/self: this is not very nice as column-visibility.dt event can change in datatables.js and not impact this one. Also the following nice sounds good and should be added to datatables.js + if (recalc === false) return; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |michaela.sieber@kit.edu, | |nick@bywatersolutions.com, | |paul.derscheid@lmscloud.de, | |philip.orr@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174797|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174837&action=edit Bug 38485: Take user's previous change into consideration for holdings tables col vis A lot happened, hard to summarize everything. Basically at this point, we have (among other things): * fixed bug 38118 (but reintroduced it with bug 36640) * fixed bug 38436 (the original report was that the is_hidden setting was no longer taken into effect on the holdings tables) Here we are trying to deal with making user's previous changes persistent across the pagination and col vis changes. Test plan: Confirm that hiding checkouts in settings hide the columns Confirm that showing checkouts then change page (*pagination*, so you need more than 20 items) and confirm that the columns are still the same Add a callnumber for an item from page 2 and confirm that the column is hidden on page 1 and shown on page 2 Hide callnumber from the settings and confirm that the column is hidden on pages 1 and 2 Show callnumber from the holdings page and confirm that the column is displayed on page 2, go page 1: hidden, go back page 2: displayed. And certainly way more other things to test, just confirm that the behaviours with this patch are consistent with what a end user would expect. Note for QA/self: this is not very nice as column-visibility.dt event can change in datatables.js and not impact this one. Also the following nice sounds good and should be added to datatables.js + if (recalc === false) return; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one is a bit confusing to me. I was testing without this patch applied: Using biblionumber = 302 * Looked at the table, inventory number and call number were now showing * Added an inventory number to one item, returend to page: column showed up * Added a callnumber to one item, returned to page: column showed up. So for items on first page it already works as expected. * Added 20+ more items. * Columns remained hidden on page 2 and were not visible at all. Applied patch. * My columns now show on the second page! :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 --- Comment #8 from Philip Orr <philip.orr@lmscloud.de> --- tested everything in the test plan, also tested setting fields to hidden + "cannot be toggled". Everything I could think of worked as the user would expect it to. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Bug 38485 depends on bug 38482, which changed state. Bug 38482 Summary: Disable save state for items tables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38482 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38724 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38724 [Bug 38724] holdings table - filters shown after column visibility is updated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43370 -- You are receiving this mail because: You are watching all bug changes.