[Bug 35203] New: Koha::Biblio->get_coins support 214 field in addition to 210 (pubyear and publisher values)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 Bug ID: 35203 Summary: Koha::Biblio->get_coins support 214 field in addition to 210 (pubyear and publisher values) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Hello, The publisher info and publication date for the <span Z3988> tag (corners) are based on the 210 but more and more records are now based on 214. Hence a loss of information. NB This is also the case for BIBTEXT and RIS formats. I will therefore propose a patch to add the new 214 field to the get->coins() method. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 158122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158122&action=edit Bug 35203: Add 214 field for pubyear and publisher values Obtain values for field 214 in addition to field 210 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158122|0 |1 is obsolete| | --- Comment #2 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 158874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158874&action=edit Bug 35203: Add 214 field for pubyear and publisher values Obtain values for field 214 in addition to field 210 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Biblio->get_coins |(UNIMARC(Koha::Biblio->get_ |support 214 field in |coins support 214 field in |addition to 210 (pubyear |addition to 210 (pubyear |and publisher values) |and publisher values) | |(UNIMARC) CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Not sure how to test correctly. I thought doing the following would result in search results after the patch was applied - I get no results after the patch is applied: 1. Start up KTD using UNIMARC: . Edit .env and change KOHA_MARC_FLAVOUR=unimarc 2. Edit any record so that: . all required fields have a value . item(s) for record display (items may need editing so that they have valid values for any lookup fields, otherwise you get a 500 error and items aren't displayed in the holdings table) 3. Edit the record so that there are unique values in 214$c (Publisher) and 214$d (Publication year). For example, Your name and 2024 4. Do advanced searches for Publisher and Publication date (Search dropdown > Advanced search) ==> Result: No results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(UNIMARC(Koha::Biblio->get_ |Koha::Biblio->get_coins |coins support 214 field in |support 214 field in |addition to 210 (pubyear |addition to 210 (pubyear |and publisher values) |and publisher values) |(UNIMARC) |(UNIMARC) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- get_coins is used to create an invisible (other than in view-source) <span> element in the bib details page which is used by COinS / OpenURL clients, so a test plan would be something like "Install Zotero and a browser Zotero extension, create or edit a bib to have publisher and date in 214, visit the details page for that bib in either the staff client or OPAC, trigger your Zotero extension on that page, verify that the citation in Zotero includes the publisher and the date published." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Phil. I had another go at testing using Zotero. My experience was: - I had a record with a 210$a, $c, and $d, and I added values for 214$c and $d. - Before the patch in the OPAC: - the values from 214$c and $d were saved to the Zotero reference (saved as a Book for the Zotero Item Type) . if I deleted the 214$c and $d values, the 210 values were saved - Before and after the patch in the staff interface: no values saved to Zotero (saved as a web page for the Zotero Item Type). - Both before and after the patch, the RIS and BIBTEX formats had the values from 210$a, $c, and $d Testing notes (using KTD): 1. Start up KTD using UNIMARC: . Edit .env and change KOHA_MARC_FLAVOUR=unimarc 2. Edit any record so that: . all required fields have a value . item(s) for record display (items may need editing so that they have valid values for any lookup fields, otherwise you get a 500 error and items aren't displayed in the holdings table) 3. Edit the record so that there are values in 214$c (Publisher) and 214$d (Publication year). For example, Your name and 2024 4. Install Zotero on your desktop and have it running: https://www.zotero.org/download/ 5. Install the Zotero Connector for your browser (download from the link in step 4). 6. View the record from step 3 in the OPAC. 7. Save the page using the Zotero Connector to create a reference. 8. Note that: - The reference is saved as a Book for Zoetero's Item Type metadata field. - The publisher and date metadata fields should be populated with the values from 214$c and $d. 9. Apply the patch and restart everything. 10. Refresh the page. 11. Repeat step 7. 12. Note that the reference created in Zotero now has: . No difference noted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39902 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35203 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from David Nind <david@davidnind.com> --- The patch no longer applies: git bz apply 35203 Bug 35203 - Koha::Biblio->get_coins support 214 field in addition to 210 (pubyear and publisher values) (UNIMARC) 158874 - Bug 35203: Add 214 field for pubyear and publisher values Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35203: Add 214 field for pubyear and publisher values Using index info to reconstruct a base tree... M Koha/Biblio.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Biblio.pm CONFLICT (content): Merge conflict in Koha/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 35203: Add 214 field for pubyear and publisher values -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org