[Bug 20859] New: SMS and other notification preferences during self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Bug ID: 20859 Summary: SMS and other notification preferences during self registration Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org Some libraries would prefer the option for patrons to choose their notification preferences and setup their SMS information during registration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- This would be great. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 31107 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I do like the sound of that. I might be adding a patch for providing the SMS alert number. Will see... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- If SMSnumber is added it would be nice to also add sms_provider_id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #4)
If SMSnumber is added it would be nice to also add sms_provider_id.
Only if the particular type of SMS messaging requires it. We use Twilio, that doesn't require this info. Koha's built in SMS through email does. I'm not sure about the iTiva (Talking Tech) setup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- That is, if iTiva has an SMS solution. I think I am mixing that one up. I know they do voice. Anyway, not all SMS solutions require a vendor preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I guess it would always have to be configurable through the *Unwanted* preference like all other fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 151688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151688&action=edit Bug 20859: Add SMSalertnumber to OPAC registration page This patch adds the SMS number field to patron self registration. To test: 1. Apply patch. 2. Make sure an SMSSendDriver 3. Go to the OPAC self registration form. 4. Notice the SMS Number field now appears. 5. Use the PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField system preferences to ensure you can hide the field and make it required. 6. Self register while adding a SMS number. Make sure that when you view the newly self-registered patron that the SMS number is properly populated in the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- I've submitted a patch that adds SMS number. Should we also add sms_provider_id here? What about messaging preferences? Should patrons be able to set those when self registering? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass from comment #9)
What about messaging preferences? Should patrons be able to set those when self registering?
That would be pretty cool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151688|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152327&action=edit Bug 20859: Add SMSalertnumber to OPAC registration page This patch adds the SMS number field to patron self registration. To test: 1. Apply patch. 2. Make sure an SMSSendDriver and some SMS cellular providers. 3. Go to the OPAC self registration form. 4. Notice the SMS Number and SMS provider fields now appear. 5. Use the PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField system preferences to ensure you can hide the fields and make them required. 6. Self register while adding a SMS number and SMS provider. Make sure that when you view the newly self-registered patron that the SMS number and SMS provider are properly populated in the staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SMS and other notification |SMS number amd SMS provider |preferences during self |during self registration |registration | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- This patch adds SMS number and SMS provider to the self registration form. I filed Bug 34003 to add messaging preferences to the self registration form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152327|0 |1 is obsolete| | --- Comment #13 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 152386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152386&action=edit Bug 20859: Add SMSalertnumber to OPAC registration page This patch adds the SMS number field to patron self registration. To test: 1. Apply patch. 2. Make sure an SMSSendDriver and some SMS cellular providers. 3. Go to the OPAC self registration form. 4. Notice the SMS Number and SMS provider fields now appear. 5. Use the PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField system preferences to ensure you can hide the fields and make them required. 6. Self register while adding a SMS number and SMS provider. Make sure that when you view the newly self-registered patron that the SMS number and SMS provider are properly populated in the staff interface. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SMS number amd SMS provider |Enter SMS number and SMS |during self registration |provider during self | |registration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + [% IF ( Koha.Preference('SMSSendDriver') ) && !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id') && action != 'edit' %] Please explain this condition. What about the case that I want to hide one of them? Is that just nonsense? Later on you test again: [% UNLESS hidden.defined('smsalertnumber') %] But you should know that already given the earlier condition. Please clarify -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #15)
+ [% IF ( Koha.Preference('SMSSendDriver') ) && !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id') && action != 'edit' %]
Please explain this condition. What about the case that I want to hide one of them? Is that just nonsense? Later on you test again: [% UNLESS hidden.defined('smsalertnumber') %] But you should know that already given the earlier condition.
Please clarify
I suppose the question is should patrons be allowed to give a SMSnumber when SMSSendDriver is turned off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #17 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- I think the question is, why does the condition contain && !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id') # which will only show the section if both fields are enabled instead of something like && ( !hidden.defined('smsalertnumber') || !hidden.defined('sms_provider_id') ) # which will show the section as long as at least one field is enabled I hadn't looked that closely at the code when I signed off, but that's a good point - from what I understand, knowing the SMS provider of individual patrons isn't always needed, so a library may want to hide sms_provider_id but still show smsalertnumber. There's no real use for knowing the provider without the number, though, so maybe the answer is to simplify the condition and only check whether smsalertnumber is hidden at that point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #16)
(In reply to Marcel de Rooy from comment #15)
+ [% IF ( Koha.Preference('SMSSendDriver') ) && !hidden.defined('smsalertnumber') && !hidden.defined('sms_provider_id') && action != 'edit' %]
Please explain this condition. What about the case that I want to hide one of them? Is that just nonsense? Later on you test again: [% UNLESS hidden.defined('smsalertnumber') %] But you should know that already given the earlier condition.
Please clarify
I suppose the question is should patrons be allowed to give a SMSnumber when SMSSendDriver is turned off?
If you want to make Koha take that into consideration for asking for it, you could. Worst case scenario is that they take a number for SMS and nothing is done with it. However, it seems, as a library, if I am going to ask for this piece of information, I would want to ensure that it is setup properly. At the very least it is on the Admin if they ask for a piece of information they are not prepared to do anything with. Does email work that way? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #19 from Magnus Enger <magnus@libriotech.no> --- Patch does not apply on main: $ git bz apply 20859 Bug 20859 - Enter SMS number and SMS provider during self registration 152386 - Bug 20859: Add SMSalertnumber to OPAC registration page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20859: Add SMSalertnumber to OPAC registration page Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt M opac/opac-memberentry.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-memberentry.pl CONFLICT (content): Merge conflict in opac/opac-memberentry.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 20859: Add SMSalertnumber to OPAC registration page hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20859-Add-SMSalertnumber-to-OPAC-registration--t9ojr3do.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152386|0 |1 is obsolete| | --- Comment #20 from Magnus Enger <magnus@libriotech.no> --- Created attachment 186049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186049&action=edit Bug 20859: Add SMSalertnumber to OPAC registration page This patch adds the SMS number field to patron self registration. To test: 1. Apply patch. 2. Make sure an SMSSendDriver and some SMS cellular providers. 3. Go to the OPAC self registration form. 4. Notice the SMS Number and SMS provider fields now appear. 5. Use the PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField system preferences to ensure you can hide the fields and make them required. 6. Self register while adding a SMS number and SMS provider. Make sure that when you view the newly self-registered patron that the SMS number and SMS provider are properly populated in the staff interface. Rebased 2025-09-02 by Magnus Enger Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #21 from Magnus Enger <magnus@libriotech.no> --- Created attachment 186050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186050&action=edit Bug 20859: Followup to fix logic in template See Bugzilla for discussion around this. This patch updates the logic so that the following requirements must be met for the "SMS number" section of the patron self registration form to be shown: - SMSSendDriver must have a value - At least one of smsalertnumber and sms_provider_id must be visible (not hidden) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #22 from Chris Cormack <chris@bigballofwax.co.nz> --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Indranil Das Gupta <indradg@l2c2.co.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186049|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 194209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194209&action=edit Bug 20859: Add SMSalertnumber to OPAC registration page This patch adds the SMS number field to patron self registration. To test: 1. Apply patch. 2. Make sure an SMSSendDriver and some SMS cellular providers. 3. Go to the OPAC self registration form. 4. Notice the SMS Number and SMS provider fields now appear. 5. Use the PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField system preferences to ensure you can hide the fields and make them required. 6. Self register while adding a SMS number and SMS provider. Make sure that when you view the newly self-registered patron that the SMS number and SMS provider are properly populated in the staff interface. Rebased 2025-09-02 by Magnus Enger Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186050|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 194210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194210&action=edit Bug 20859: Followup to fix logic in template See Bugzilla for discussion around this. This patch updates the logic so that the following requirements must be met for the "SMS number" section of the patron self registration form to be shown: - SMSSendDriver must have a value - At least one of smsalertnumber and sms_provider_id must be visible (not hidden) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds SMS release notes| |number and SMS provider | |fields to the OPAC | |registration page, allowing | |patrons to provide these | |when self-registering. | | | |Whether they appear on the | |registration forms is | |determined by a combination | |of: | |- | |PatronSelfRegistrationBorro | |werMandatoryField system | |preference | |- | |PatronSelfRegistrationBorro | |werUnwantedField | |- SMSSendDriver system | |preference | |- SMS providers set up at | |Administration > Additional | |parameters > SMS cellular | |providers | | | |Note that: | |- if SMSSendDriver is not | |set (even if SMS providers | |are set up), the fields are | |not shown. | |- if SMSSendDriver and SMS | |providers are set up, then | |the fields are shown and | |are mandatory CC| |david@davidnind.com --- Comment #25 from David Nind <david@davidnind.com> --- Note that if I add the SMS fields to both PatronSelfRegistrationBorrowerMandatoryField and PatronSelfRegistrationBorrowerUnwantedField, the SMS fields show up on the self-registration form. Even if I complete all the required fields I get: "You have not filled out all required fields. Please fill in all missing fields and resubmit." I couldn't work out how to make the fields optional - that is, have them there, but not make it mandatory to add information to them. Testing notes (using KTD): 1. Step 2: Add some dummy SMS providers at Administration > Additional parameters > SMS cellular providers 2. Tested making fields mandatory using PatronSelfRegistrationBorrowerMandatoryField system preference - should be marked as required, and you can't submit the self-registration form unless completed: - SMS provider ID (internal) (sms_provider_id) - Mobile phone number (smsalertnumber) 3. Test hiding the fields using PatronSelfRegistrationBorrowerUnwantedField system preference - should not be shown on the self-registration form and you can successfully submit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing status: Does not apply. And please respond to former comment from David. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org