[Bug 22322] New: Self-checkin module should provide for automatic logins (like self-checkout)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Bug ID: 22322 Summary: Self-checkin module should provide for automatic logins (like self-checkout) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oliver.behnke@aei.mpg.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- The self-checkin (SCI) module currently requires to set up a dedicated kiosk terminal for its purpose. The reason being that you can't provide user/password system preferences for an automatic login, like you can for the self-checkout (SCO) counterpart. Our use case is the following: we are already using the SCO module with automatic login of the dedicated SCO patron, and our actual patrons identify themselves via their cardnumber. While they can obviously check in their books via the SCO module, we'd like to streamline the process such that they don't have to login with their cardnumber in order to simply return a book. The SCI module would be ideal for this but, effectively, it can't be used on the same terminal as switching between the modules currently requires a manual login of the dedicated SCI patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #1 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Related: going forward I think it would be useful to have a dedicated "Component" for the self checkin module as well (see the self checkout component). Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Claudio <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Derryn <derrynj@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15492 CC| |lari.taskula@hypernova.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 [Bug 15492] Stand alone self check-in tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |emmi.takkinen@koha-suomi.fi Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 123299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123299&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Set "SelfCheckoutByLogin" as "cardnumber". 2. Find patron with loan or add one. 3. Go to /cgi-bin/koha/sco/sco-main.pl 4. Return loan by passing items barcode => confirm loans is returned succesfully Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Hi Emmi, Sadly this no longer applies. Any chance we could get a rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123299|0 |1 is obsolete| | --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139170&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Set "SelfCheckoutByLogin" as "cardnumber". 2. Find patron with loan or add one. 3. Go to /cgi-bin/koha/sco/sco-main.pl 4. Return loan by passing items barcode => confirm loans is returned succesfully Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139170|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140162&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Set "SelfCheckoutByLogin" as "cardnumber". 2. Find patron with loan or add one. 3. Go to /cgi-bin/koha/sco/sco-main.pl 4. Return loan by passing items barcode => confirm loans is returned succesfully Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Emmi, there are several problems highlighted by the QA tools, can you please fix? For fixing the filters there is a handy script: misc/devel/add_missing_filters.pl. FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco-self.inc FAIL filters missing_filter at line 7 ( <a class="brand" href="/cgi-bin/koha/sco/sco-main.pl"><img src="[% interface %]/[% theme %]/images/koha-logo-navbar.png" alt=""></a>) missing_filter at line 7 ( <a class="brand" href="/cgi-bin/koha/sco/sco-main.pl"><img src="[% interface %]/[% theme %]/images/koha-logo-navbar.png" alt=""></a>) missing_filter at line 31 ( [% opacheader %]) OK koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt FAIL filters missing_filter at line 486 ( <b>[% checkinmessage %]</b>) missing_filter at line 589 ( if ( (Date.now() - confirmStart) < [% SelfCheckTimeout %] ) {) missing_filter at line 590 ( window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[% borrowernumber %]&print=qslip");) FAIL opac/sco/sco-main.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL forbidden patterns forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 79) forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 135) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 143764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143764&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem@etf.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 30590 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143764|0 |1 is obsolete| | --- Comment #9 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 150770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150770&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150770|0 |1 is obsolete| | --- Comment #10 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 150776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150776&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy Signed-off-by: hinemoea <hinemoea@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #11 from David Nind <david@davidnind.com> --- Hi Hinemoea. Another one for you to change the status to Signed Off, so that you get the credit on the dashboard. 8-) David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin@ub.lu.se --- Comment #12 from Stina Hallin <stina.hallin@ub.lu.se> --- I tried to sign off, but the checkin was not always returned successfully when I checked the patron details. Sometimes it worked as it should, but I didn't manage to see why it worked sometimes, and sometimes failed. I tried waiting until the sco-page logged out, and sometimes it worked on the first try but not the next. I tried using both the Submit button and return key. Once it worked when I changed home library for the patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #13 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Setting this as ASSIGNED based on Stinas comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #14 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Stina Hallin from comment #12)
I tried to sign off, but the checkin was not always returned successfully when I checked the patron details. Sometimes it worked as it should, but I didn't manage to see why it worked sometimes, and sometimes failed. I tried waiting until the sco-page logged out, and sometimes it worked on the first try but not the next. I tried using both the Submit button and return key. Once it worked when I changed home library for the patron.
I'm unable to repeat this. I was able to return several loans of several different patrons. Both items and patrons had different homebranch than library I was logged in on sco-page. Patch needs rebase, so I'll do that and set this back "Needs Signoff" to get more feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140162|0 |1 is obsolete| | --- Comment #15 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 161722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161722&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Set "SelfCheckoutByLogin" as "cardnumber". 2. Find patron with loan or add one. 3. Go to /cgi-bin/koha/sco/sco-main.pl 4. Return loan by passing items barcode => confirm loans is returned succesfully Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150776|0 |1 is obsolete| | --- Comment #16 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 161723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161723&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy Signed-off-by: hinemoea <hinemoea@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(... git bz apply 22322 Bug 22322 - Self-checkin module should provide for automatic logins (like self-checkout) 161722 - Bug 22322: Self check-in without log in 161723 - Bug 22322: Fix QA issues Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22322: Self check-in without log in Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt M opac/sco/sco-main.pl Falling back to patching base and 3-way merge... Auto-merging opac/sco/sco-main.pl CONFLICT (content): Merge conflict in opac/sco/sco-main.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 22322: Self check-in without log in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161722|0 |1 is obsolete| | --- Comment #18 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 165722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165722&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Set "SelfCheckoutByLogin" as "cardnumber". 2. Find patron with loan or add one. 3. Go to /cgi-bin/koha/sco/sco-main.pl 4. Return loan by passing items barcode => confirm loans is returned succesfully Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161723|0 |1 is obsolete| | --- Comment #19 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 165723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165723&action=edit Bug 22322: Fix QA issues This patch fixes following QA issues: - Add missing filters - Use dt_from_string instead of DateTime->now in sco-main.pl Following issue is left unchanged, since it is purposeful: forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error Sponsored-by: Koha-Suomi Oy Signed-off-by: hinemoea <hinemoea@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #20 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from David Nind <david@davidnind.com> --- I get an error page if I enter a barcode and press 'Submit': Sorry, the requested page is not available Error 403 In additional, if I log in to the self checkout system and go to check in the item that way, I get this error: Can't call method "homebranch" on an undefined value at /kohadevbox/koha/opac/sco/sco-main.pl line 180 in (eval) at /kohadevbox/koha/opac/sco/sco-main.pl line 180 177: if( !$checkinitem ){ 178: $checkinmessage = "Item not found."; 179: } 180: my $tobranch = $checkinitem->homebranch; 181: 182: my ($return_success,$messages,$issueinformation,$borrower) = AddReturn($uibarcode,$branch,undef,$today) unless !$success; ..... One other comment: - The title "Self checkout system" doesn't make sense, so maybe it should be changed to "Self service" or "Self service system". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #22 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Looking this again and this needs some rework. It doesn't take into account e.g. changes made in bug 32256 and is full of code that is useless. Setting this back to assigned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #23 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Just a few words of encouragement: thanks Emmi (and everyone else) for your continued effort to get this implemented! It's highly appreciated! Cheers :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #24 from Lari Taskula <lari.taskula@hypernova.fi> --- We have been using a Koha plugin for this. https://github.com/Hypernova-Oy/koha-plugin-self-checkout-checkin It adds a simple screen with two buttons that navigate you either to SCO or SCI. When you select SCO, you get the default Koha SCO functionality. When you select SCI, it automatically authenticates a SCI-machine account (configured in the plugin's settings) in the background (through REST API) so a patron may access SCI without logging in manually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165722|0 |1 is obsolete| | Attachment #165723|0 |1 is obsolete| | --- Comment #25 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 178815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178815&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Find patron with loan or add one. 2. Go to /cgi-bin/koha/sco/sco-main.pl. 3. Return loan by passing items barcode. => Confirm loans is returned succesfully. 4. Attempt to return item again. => Confirm that "Item not checked in:..." message is displayed. 5. Attempt to return empty barcode field. => Confirm that "Please enter barcode." message is displayed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178815|0 |1 is obsolete| | --- Comment #26 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 179010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179010&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Find patron with loan or add one. 2. Go to /cgi-bin/koha/sco/sco-main.pl. 3. Return loan by passing items barcode. => Confirm loans is returned succesfully. 4. Attempt to return item again. => Confirm that "Item not checked in:..." message is displayed. 5. Attempt to return empty barcode field. => Confirm that "Please enter barcode." message is displayed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179010|0 |1 is obsolete| | --- Comment #27 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 180953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180953&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Find patron with loan or add one. 2. Go to /cgi-bin/koha/sco/sco-main.pl. 3. Return loan by passing items barcode. => Confirm loans is returned succesfully. 4. Attempt to return item again. => Confirm that "Item not checked in:..." message is displayed. 5. Attempt to return empty barcode field. => Confirm that "Please enter barcode." message is displayed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #28 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 180954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180954&action=edit Bug 22322: Don't log login failure to action_logs when page is refreshed If sysprefs AuthFailureLog and SelfCheckoutByLogin are enabled and one logs in to the SCO from OPAC or refreshes the SCOs login page, this is added to the action_logs table as an authentication failure. We shouldn't log when this happens since these are not real login attempts. To test: 1. Make sure you have AuthFailureLog enabled. 2. Check how many rows are returned from database with following query: SELECT count(*) FROM action_logs WHERE module = "AUTH" and action = "FAILURE"; 3. Enable syspref SelfCheckoutByLogin. 4. Navigate to SCO page and login to OPAC when asked. 5. After SCO login page is displayed, check database again. => Result has now increased by 1. 6. Refresh page. => Result has again increased by 1. 7. Apply this patch, restart services if needed. 8. Login to SCO again from OPAC again or just refresh the page. 9. Check database. => Confirm that result hasn't increased. 10. Refresh page and check database. => Confirm that result hasn't increased. 11. Confirm that login to SCO still works as it should. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lin-wei.li@inLibro.com --- Comment #29 from Lin Wei <lin-wei.li@inLibro.com> --- Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180953|0 |1 is obsolete| | --- Comment #30 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 182337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182337&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Find patron with loan or add one. 2. Go to /cgi-bin/koha/sco/sco-main.pl. 3. Return loan by passing items barcode. => Confirm loans is returned succesfully. 4. Attempt to return item again. => Confirm that "Item not checked in:..." message is displayed. 5. Attempt to return empty barcode field. => Confirm that "Please enter barcode." message is displayed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180954|0 |1 is obsolete| | --- Comment #31 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 182338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182338&action=edit Bug 22322: Don't log login failure to action_logs when page is refreshed If sysprefs AuthFailureLog and SelfCheckoutByLogin are enabled and one logs in to the SCO from OPAC or refreshes the SCOs login page, this is added to the action_logs table as an authentication failure. We shouldn't log when this happens since these are not real login attempts. To test: 1. Make sure you have AuthFailureLog enabled. 2. Check how many rows are returned from database with following query: SELECT count(*) FROM action_logs WHERE module = "AUTH" and action = "FAILURE"; 3. Enable syspref SelfCheckoutByLogin. 4. Navigate to SCO page and login to OPAC when asked. 5. After SCO login page is displayed, check database again. => Result has now increased by 1. 6. Refresh page. => Result has again increased by 1. 7. Apply this patch, restart services if needed. 8. Login to SCO again from OPAC again or just refresh the page. 9. Check database. => Confirm that result hasn't increased. 10. Refresh page and check database. => Confirm that result hasn't increased. 11. Confirm that login to SCO still works as it should. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Lin Wei <lin-wei.li@inLibro.com> --- # Commit 182337 ## Test Results Commit 182337 (Self check-in without log it) works, but I found an edge case when attempting to check in a book that is currently checked in AND in transit. ## Test Execution 1. Apply commit 182337. 2. In Intranet, add books with the following barcodes to a Patron: 1234, 0001, 0002. 3. Go to /cgi-bin/koha/sco/sco-main.pl. 4. Return 1234 => success. 5. Return 1234 => fail with error 500 Internal Server Error. 6. Go back to /cgi-bin/koha/sco/sco-main.pl. 7. Return 0001 => success. 8. Return 0001 => "Item not checked in: ..." 9. Return 0001 => "Item not checked in: ..." 10. Return 0002 => success. 11. Return 0002 => "Item not checked in: ..." 12. Return 0002 => "Item not checked in: ..." ## Additional Notes Fake books are just test entries and are missing a lot of data. Real books are, well, real books with real data. - 1234: fake book, home_library=A, current_library=Centerville, status="In transit from Centerville to A since 05/13/2025" - 0001: real book, home_library=Centerville, current_library=Centerville - 0002: fake book, home_library=Centerville, current_library=Centerville ===== # Commit 182338 ## Test Results I was a bit confused by steps 4 and 8 asking me to log in: I think the focus of the bug is on the login page, not the SCO page after being logged in. In any case, I decided to be extra thourough and test everything: what I believe needs to be tested and what I think the test plan is asking for. In conclusion, I am pretty sure everything works as expected. ## Test Execution 1. Enable AuthFailureLog. 2. Check number of failure logs in database with provided query => count=79. 3. Navigate to SCO page. 4. Check count => 80. 5. Refresh page. 6. Check count => 81. 7. Log in. 8. Check count => 81. 9. Refresh page while logged in. 10. Check count => 81. 11. Log out via: Finish > End Session. 12. Check count => 82. 13. Attempt to log in with incorrect credentials. 14. Check count => 83. 15. Apply patch. 16. Check count => 83. 17. Refresh already opened SCO page. 18. Check count => 84. 19. Refresh again. 20. Check count => 84. 21. Log in. 22. Check count => 84. 23. Log out via: Finish > End Session. 24. Check count => 84. 25. Attempt to log in with incorrect credentials. 26. Check count => 85. ===== TLDR: Everything works except that edge case for 182337. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #33 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Lin Wei from comment #32)
# Commit 182337
## Test Results
Commit 182337 (Self check-in without log it) works, but I found an edge case when attempting to check in a book that is currently checked in AND in transit.
## Test Execution
1. Apply commit 182337. 2. In Intranet, add books with the following barcodes to a Patron: 1234, 0001, 0002. 3. Go to /cgi-bin/koha/sco/sco-main.pl. 4. Return 1234 => success. 5. Return 1234 => fail with error 500 Internal Server Error. 6. Go back to /cgi-bin/koha/sco/sco-main.pl. 7. Return 0001 => success. 8. Return 0001 => "Item not checked in: ..." 9. Return 0001 => "Item not checked in: ..." 10. Return 0002 => success. 11. Return 0002 => "Item not checked in: ..." 12. Return 0002 => "Item not checked in: ..."
## Additional Notes
Fake books are just test entries and are missing a lot of data. Real books are, well, real books with real data.
- 1234: fake book, home_library=A, current_library=Centerville, status="In transit from Centerville to A since 05/13/2025" - 0001: real book, home_library=Centerville, current_library=Centerville - 0002: fake book, home_library=Centerville, current_library=Centerville
=====
# Commit 182338
## Test Results
I was a bit confused by steps 4 and 8 asking me to log in: I think the focus of the bug is on the login page, not the SCO page after being logged in. In any case, I decided to be extra thourough and test everything: what I believe needs to be tested and what I think the test plan is asking for. In conclusion, I am pretty sure everything works as expected.
## Test Execution
1. Enable AuthFailureLog. 2. Check number of failure logs in database with provided query => count=79. 3. Navigate to SCO page. 4. Check count => 80. 5. Refresh page. 6. Check count => 81. 7. Log in. 8. Check count => 81. 9. Refresh page while logged in. 10. Check count => 81. 11. Log out via: Finish > End Session. 12. Check count => 82. 13. Attempt to log in with incorrect credentials. 14. Check count => 83. 15. Apply patch. 16. Check count => 83. 17. Refresh already opened SCO page. 18. Check count => 84. 19. Refresh again. 20. Check count => 84. 21. Log in. 22. Check count => 84. 23. Log out via: Finish > End Session. 24. Check count => 84. 25. Attempt to log in with incorrect credentials. 26. Check count => 85.
=====
TLDR: Everything works except that edge case for 182337.
Thank you for testing this throughout! Check in doesn't handle setting transit as it should, it tries to set "reason" value as "ResFound" which has been replaced with "Reserve" and it's not saved to database. When item is checked in again it fails with error "The reason parameter is mandatory". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #34 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 189512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189512&action=edit Bug 22322: Handle setting transfer status correctly If one checked in an item which has a hold and which should be put in transfer, reason for transfer was set as "ResFound". This has been replaced with "Reserve" and using wrong reason parameter lead to error "The reason parameter is mandatory". Also if wrong transfer was detected, SCO would fail with error since branch where item should be transfered couldn't be determined just using the old transfers branchcode. To test: 1. Apply this patch. 2. Find an item which is checked out and has holds for a patron in different library. 3. Return item via SCO check in from SCO main page. => Item should be checked in succesfully. 4. Find an item which is in transit from a branch A to B and check it out from branch C. => Koha shouldn't fail on error. Also fix QA tool issues. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 --- Comment #35 from David Nind <david@davidnind.com> --- Is this ready for testing? (The status is still Failed QA.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #36 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to David Nind from comment #35)
Is this ready for testing? (The status is still Failed QA.)
Yes it is, I just forgot to change the status :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris.mathevet@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182337|0 |1 is obsolete| | --- Comment #37 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 198997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198997&action=edit Bug 22322: Self check-in without log in One should be able to return loans via SCO without login required. This patch adds check in box where patrons can check in their loans with barcode. To test: 1. Find patron with loan or add one. 2. Go to /cgi-bin/koha/sco/sco-main.pl. 3. Return loan by passing items barcode. => Confirm loans is returned succesfully. 4. Attempt to return item again. => Confirm that "Item not checked in:..." message is displayed. 5. Attempt to return empty barcode field. => Confirm that "Please enter barcode." message is displayed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182338|0 |1 is obsolete| | --- Comment #38 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 198998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198998&action=edit Bug 22322: Don't log login failure to action_logs when page is refreshed If sysprefs AuthFailureLog and SelfCheckoutByLogin are enabled and one logs in to the SCO from OPAC or refreshes the SCOs login page, this is added to the action_logs table as an authentication failure. We shouldn't log when this happens since these are not real login attempts. To test: 1. Make sure you have AuthFailureLog enabled. 2. Check how many rows are returned from database with following query: SELECT count(*) FROM action_logs WHERE module = "AUTH" and action = "FAILURE"; 3. Enable syspref SelfCheckoutByLogin. 4. Navigate to SCO page and login to OPAC when asked. 5. After SCO login page is displayed, check database again. => Result has now increased by 1. 6. Refresh page. => Result has again increased by 1. 7. Apply this patch, restart services if needed. 8. Login to SCO again from OPAC again or just refresh the page. 9. Check database. => Confirm that result hasn't increased. 10. Refresh page and check database. => Confirm that result hasn't increased. 11. Confirm that login to SCO still works as it should. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189512|0 |1 is obsolete| | --- Comment #39 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 198999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198999&action=edit Bug 22322: Handle setting transfer status correctly If one checked in an item which has a hold and which should be put in transfer, reason for transfer was set as "ResFound". This has been replaced with "Reserve" and using wrong reason parameter lead to error "The reason parameter is mandatory". Also if wrong transfer was detected, SCO would fail with error since branch where item should be transfered couldn't be determined just using the old transfers branchcode. To test: 1. Apply this patch. 2. Find an item which is checked out and has holds for a patron in different library. 3. Return item via SCO check in from SCO main page. => Item should be checked in succesfully. 4. Find an item which is in transit from a branch A to B and check it out from branch C. => Koha shouldn't fail on error. Also fix QA tool issues. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #40 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #41 from David Nind <david@davidnind.com> --- I've Failed QA because of: 1. qa script complains about tidiness: [FAIL] opac/sco/sco-main.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl opac/sco/sco-main.pl` 2. When I go to check in using the new "Check in" section on the SCO page, I get an Error 403. A consolidated test plan with the sequence things should be done in would help a lot. Testing notes (using KTD): 1. Set up for testing: - Checked out 39999000011418 to Mary Burton - Changed Mary Burton's user name and password so I can log in to the OPAC - Mary Burton's card number: 23529000651225 - URL for OPAC SCO log in: 127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl 2. Sequence used for testing: - Work through second patch test plan until patch needs applying - Apply all patches - Restart everything: restart_all - Work through rest of the test plan for the second patch - Work through the test plans in the first and third patches 3. Second patch testing: - Step 1: Set AuthFailureLog to "Log" - Step 2: Query returns 0 on a fresh system - Steps 3 to 6: With SelfCheckoutByLogin set to the default "username and password" . SQL result from step 2 increases by 1 (returns 1) . Refresh page: does NOT increase by 1 . Hard page refresh: does NOT increase by 1 . Clear browser cache: does increase by 1 - Steps 3 to 6: With SelfCheckoutByLogin set to "card number" . SQL result from step 2 does NOT increase . Refresh page: does NOT increase by 1 . Hard page refresh: does NOT increase by 1 . Clear browser cache: does NOT increase by 1 4. Apply all the patches and restart everything (restart_all) 5. Continue testing second patch: - With SelfCheckoutByLogin set to "username and password": no increases - With SelfCheckoutByLogin set to "card number": no increases 6. First patch testing: - Page has two sections: . Check out . Check in - Get Error 403 page after entering the barcode and pressing submit 7. Third patch testing: - Place a hold on Programming Perl for patron Joyce Gaines (Springfield) - Check in: same error 403 as per step 5 - Step 4: is this from SCO, or a normal check in using the staff interface? An example here would help. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org