https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Lin Wei <lin-wei.li@inLibro.com> --- # Commit 182337 ## Test Results Commit 182337 (Self check-in without log it) works, but I found an edge case when attempting to check in a book that is currently checked in AND in transit. ## Test Execution 1. Apply commit 182337. 2. In Intranet, add books with the following barcodes to a Patron: 1234, 0001, 0002. 3. Go to /cgi-bin/koha/sco/sco-main.pl. 4. Return 1234 => success. 5. Return 1234 => fail with error 500 Internal Server Error. 6. Go back to /cgi-bin/koha/sco/sco-main.pl. 7. Return 0001 => success. 8. Return 0001 => "Item not checked in: ..." 9. Return 0001 => "Item not checked in: ..." 10. Return 0002 => success. 11. Return 0002 => "Item not checked in: ..." 12. Return 0002 => "Item not checked in: ..." ## Additional Notes Fake books are just test entries and are missing a lot of data. Real books are, well, real books with real data. - 1234: fake book, home_library=A, current_library=Centerville, status="In transit from Centerville to A since 05/13/2025" - 0001: real book, home_library=Centerville, current_library=Centerville - 0002: fake book, home_library=Centerville, current_library=Centerville ===== # Commit 182338 ## Test Results I was a bit confused by steps 4 and 8 asking me to log in: I think the focus of the bug is on the login page, not the SCO page after being logged in. In any case, I decided to be extra thourough and test everything: what I believe needs to be tested and what I think the test plan is asking for. In conclusion, I am pretty sure everything works as expected. ## Test Execution 1. Enable AuthFailureLog. 2. Check number of failure logs in database with provided query => count=79. 3. Navigate to SCO page. 4. Check count => 80. 5. Refresh page. 6. Check count => 81. 7. Log in. 8. Check count => 81. 9. Refresh page while logged in. 10. Check count => 81. 11. Log out via: Finish > End Session. 12. Check count => 82. 13. Attempt to log in with incorrect credentials. 14. Check count => 83. 15. Apply patch. 16. Check count => 83. 17. Refresh already opened SCO page. 18. Check count => 84. 19. Refresh again. 20. Check count => 84. 21. Log in. 22. Check count => 84. 23. Log out via: Finish > End Session. 24. Check count => 84. 25. Attempt to log in with incorrect credentials. 26. Check count => 85. ===== TLDR: Everything works except that edge case for 182337. -- You are receiving this mail because: You are watching all bug changes.