[Bug 38687] New: Batch extend due dates should be called Batch modify due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Bug ID: 38687 Summary: Batch extend due dates should be called Batch modify due dates Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: hebah@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The batch extend due dates tool can be used not just to extend due dates but to set earlier ones. Calling it 'batch modify due dates' better describes its function and makes it more consistent with other tool names. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #1 from Aude Charillon <aude.charillon@ptfs-europe.com> --- I would support this change of name. The description for the tool on the Tools page should also be updated to something clearer. At the moment, the description is: "Modify the due date checkouts in batch". I would suggest replacing it by: "Modify checkout due dates in batch". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 --- Comment #2 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 176651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176651&action=edit Bug 38687: update "batch modify due dates" and description "Modify the due date checkouts in batch" to test: - go to Tool - check designation and description of "batch modify due date" - verify designation ist "batch modify due date" and description is "Modify the due date checkouts in batch" - apply patch - verify instead of "batch modify due date" it is now "Batch modify due dates" and instead of "Modify the due date checkouts in batch" it is "Modify checkout due dates in batch" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Janne Seppänen <janne.seppanen@lahti.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janne.seppanen@lahti.fi Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Janne Seppänen <janne.seppanen@lahti.fi> --- Tried testing on the ByWater Solutions sandbox, but applying the patch ends up in error: Bug 38687 - Batch extend due dates should be called Batch modify due dates 176651 - Bug 38687: update "batch modify due dates" and description "Modify the due date checkouts in batch" Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 38687: update "batch modify due dates" and description "Modify the due date checkouts in batch" Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_extend_due_dates.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 38687: update "batch modify due dates" and description "Modify the due date checkouts in batch" [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38687-update-batch-modify-due-dates-and-descri-55dxiw_1.patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nicolas.hunstein@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176651|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178580&action=edit Bug 38687: update "batch modify due dates" and description "Modify the due date checkouts in batch" to test: - go to Tool - check designation and description of "batch modify due date" - verify designation ist "batch modify due date" and description is "Modify the due date checkouts in batch" - apply patch - verify instead of "batch modify due date" it is now "Batch modify due dates" and instead of "Modify the due date checkouts in batch" it is "Modify checkout due dates in batch" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- When I apply the patch, the tool disappears. I think it has to do with the permission name change. But I'm not sure what I'm doing wrong, or what I should be doing... I did git bz apply and then I did restart_all on my ktd. I also did ./misc/installer/data/updatedatabase.pl inside ktd shell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Janne Seppänen <janne.seppanen@lahti.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Janne Seppänen <janne.seppanen@lahti.fi> --- Tested this in the BibLibre sandbox, and the patch installs without errors. However I'm getting the same issue as Caroline, the tool has now disappeared entirely from the Tools list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This will require a database update for the change of the permission name. There might also be some other changes required to make this fully work (I wonder if we have checks on the permission in .pl files as well). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org