https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40297 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40295 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40297 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #0)

bug 40295 implemented would have prevented Bug 40292.

But there is a larger problem of CI not in sync with https://wiki.koha-community.org/wiki/System_requirements_and_recommendations.

We need to review those requirements. I rely on RMaints to let me know which tasks they need added, I can do it timely if requested. Does this report imply adding this? * main + MariaDB 10.3 * 25.05 + MariaDB 10.3 Which OS should we use? MariaDB runs on a separate container so we don't need the backend to support that specific version. There are some hardcoded MariaDB versions though: https://gitlab.com/koha-community/koha-testing-docker/-/blob/main/jenkins_co... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40297 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #1)

We could have a 10.3 task, but what do you think of our supported OS not providing support for it?

It's advertised so even if it's a mistake, it makes sense to still have it for the end of the cycle. It seems in the last dev meeting, the scale tilted in favor of not dropping 10.3, which was a proposed solution to that RENAME COLUMN issue. 22.11 LTS still advertises Ubuntu 20.04 which ships with MariaDB 10.3 by default IIUC. And Ubuntu 20.04 is only EOL since a month. MariaDB 10.3 is EOL since 2 years so unless we hear enough about explicit usage it won't make sense to keep it around next cycle. (IMHO) The person that hit the RENAME COLUMN issue didn't realize their Debian 10 is EOL since a year. And they will upgrade it. ------- (In reply to Tomás Cohen Arazi (tcohen) from comment #2)

(In reply to Victor Grousset/tuxayo from comment #0) We need to review those requirements. I rely on RMaints to let me know which tasks they need added

+1, because on a new cycle, we can easily forget stuff that is way past EOL. It's very possible that we wouldn't have advertised MariaDB 10.3 for 25.05. I'm not sure where in our processes it would be a good place to refresh the requirements. -----

Does this report imply adding this?

* main + MariaDB 10.3 * 25.05 + MariaDB 10.3

Maybe I'm wrong but it doesn't look likely that we will support MariaDB 10.3 for 25.11. So what about just 25.05? So there is a decent safeguard for MariaDB 10.3 without spending too much setup time and runner resources for that 2 years old EOL DBMS. Not sure adding jobs for 24.11, 24.05, 22.11 has a meaningful chance of catching a bug that the 25.05 job wouldn't. ------ (In reply to Tomás Cohen Arazi (tcohen) from comment #3)

I've just patched KTD so we have more flexibility [1] and created a task for main+10.3 [2] to test if my patch does the job.

Cool, thanks! :D These mariadb_d11, etc images are a bit confusing so being able to add directly a MariaDB version is more simple. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40297 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

Does this report imply adding this?

I don't remember why I though main and stable. But I certainly wasn't aware that MariaDB 10.3 was totally EOL ^^" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40297 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The tickets in the "project infrastructure" are bound to have no patch part of the time. But they should have some guidance in how a third party can double check the work done is doing what it's expected. Anyway, here I see we have a dedicated CI job now :D https://jenkins.koha-community.org/view/main/job/Koha_Main_MDB_10.3 Which passes and run the light test suite. Makes sense. Time has passed but MariaDB 10.3 is still needed because that's what Ubuntu 20.04 ships [1] and we still advertise it's support (even if 20.04 is EOL our LTS supports it) along with explicit MariaDB 10.3 All seem coherent, thanks Tomás :) Straight to passed QA. [1] https://repology.org/project/mariadb/versions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40297 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |FIXED --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #7)

The tickets in the "project infrastructure" are bound to have no patch part of the time.

But they should have some guidance in how a third party can double check the work done is doing what it's expected.

Anyway, here I see we have a dedicated CI job now :D https://jenkins.koha-community.org/view/main/job/Koha_Main_MDB_10.3 Which passes and run the light test suite. Makes sense.

Time has passed but MariaDB 10.3 is still needed because that's what Ubuntu 20.04 ships [1] and we still advertise it's support (even if 20.04 is EOL our LTS supports it) along with explicit MariaDB 10.3

All seem coherent, thanks Tomás :) Straight to passed QA.

[1] https://repology.org/project/mariadb/versions

Closing this. Gonna handle it somewhere else. -- You are receiving this mail because: You are watching all bug changes.