[Bug 38465] New: Cannot schedule a curbside pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Bug ID: 38465 Summary: Cannot schedule a curbside pickup Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When searching for patron the autocomplete code raised a JS error in the console: Uncaught TypeError: m.tz is not a function -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36454 [Bug 36454] Provide indication if a patron is expired or restricted on patron search autocomplete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174661&action=edit Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This is fixed by the follow-up in bug 36454: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36454&attachment=174671 Can't reproduce the issue after applying the patch from there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | Resolution|FIXED |--- Severity|critical |minor Status|RESOLVED |REOPENED --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #2)
This is fixed by the follow-up in bug 36454: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. html&bug=36454&attachment=174671
Can't reproduce the issue after applying the patch from there.
Yes, but it is still "valid" in the sense that the patch removes 2 includes that are already included. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- No longer critical however. New test plan: confirm that the curbide pickup module is still working correctly, ie. you can schedule a new pickup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174661|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 175041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175041&action=edit Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Curbside pickup continues to work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175041|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 175442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175442&action=edit Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes duplicated release notes| |JavaScript library includes | |from the curbside pickup | |page, as they are now | |included in the main | |include. (This is a | |follow-up to bug 36454 - | |Provide indication if a | |patron is expired or | |restricted on patron search | |autocomplete, a new feature | |added in Koha 24.11.00.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- not backporting to 24.05.x unless requested - dependency not in 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00, 24.11.02 released in| | Status|Pushed to main |Pushed to stable CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This was pushed for 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38465 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from David Nind <david@davidnind.com> --- This fixes a bug in an enhancement in bug 36454, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org