[Bug 36092] New: sessionID not passed to the template on auth.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Bug ID: 36092 Summary: sessionID not passed to the template on auth.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org The session's ID is not passed to the template and not stored in the context when we are on the authentication page. It can be problematic, for instance we will not be able to generate a CSRF token for the login form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34478 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162139&action=edit Bug 36092: Add test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162140&action=edit Bug 36092: Pass the sessionID from checkauth if we hit auth If we hit the auth page we were not passing sessionID to the template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162141&action=edit Bug 36092: Pass sessionID at the end of get_template_and_user It seems safer to pass the logged in user and session info at the end of the sub. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35890 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Do not trust me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162139|0 |1 is obsolete| | Attachment #162140|0 |1 is obsolete| | Attachment #162141|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162142&action=edit Bug 36092: Add test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162143&action=edit Bug 36092: Pass the sessionID from checkauth if we hit auth If we hit the auth page we were not passing sessionID to the template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162144&action=edit Bug 36092: Pass sessionID at the end of get_template_and_user It seems safer to pass the logged in user and session info at the end of the sub. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I'm getting a sha1 error when applying the patches: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36092: Add test error: sha1 information is lacking or useless (t/db_dependent/Auth.t). error: could not build fake ancestor Patch failed at 0001 Bug 36092: Add test I was going to make sure that the tests (prove prove t/db_dependent/Auth.t) pass before and after the patches are applied. Is there anything else required to sign off/test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162142|0 |1 is obsolete| | Attachment #162143|0 |1 is obsolete| | Attachment #162144|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 162158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162158&action=edit Bug 36092: Add test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 162160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162160&action=edit Bug 36092: Pass the sessionID from checkauth if we hit auth If we hit the auth page we were not passing sessionID to the template Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 162161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162161&action=edit Bug 36092: Pass sessionID at the end of get_template_and_user It seems safer to pass the logged in user and session info at the end of the sub. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162158|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162189&action=edit Bug 36092: Add test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162160|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162190&action=edit Bug 36092: Pass the sessionID from checkauth if we hit auth If we hit the auth page we were not passing sessionID to the template Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162161|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162191&action=edit Bug 36092: Pass sessionID at the end of get_template_and_user It seems safer to pass the logged in user and session info at the end of the sub. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This makes a lot of sense and is well covered by tests. I'm happy I couldn't find any regressions. QA scripts are happy too. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to master for 24.05.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- In 23.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it in 22.05.x but not in 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Bug 36092 depends on bug 35890, which changed state. Bug 35890 Summary: AutoLocation system preference + setting the library IP field - can still login and unexpected results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35890 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.03,23.05.09 |24.05.00,23.11.03,23.05.09, released in| |22.11.29 CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Pushed to 22.11.x for 22.11.29 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.03,23.05.09, |24.05.00,23.11.03,23.05.09 released in|22.11.29 | Status|Needs documenting |Pushed to oldoldstable --- Comment #21 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Wainui Witika-Park from comment #20)
Pushed to 22.11.x for 22.11.29
Actually I have reverted this as the tests don't pass Please supply a 22.11 patch if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting --- Comment #22 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36092 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #23 from David Nind <david@davidnind.com> --- Bug fix, no change to the user interfaces as far as I can tell, no changes to the manual requried. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org