[Bug 28840] New: Better texts in batch record modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Bug ID: 28840 Summary: Better texts in batch record modification/deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28839 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123723&action=edit Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123724&action=edit Screenshot with patch (modification) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123725&action=edit Screenshot with patch (deletion) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |samu.heiskanen@hypernova.fi --- Comment #4 from Samu Heiskanen <samu.heiskanen@hypernova.fi> --- Applying: Bug 28840: Better texts in batch record modification/deletion Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 28840: Better texts in batch record modification/deletion hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28840-Better-texts-in-batch-record-modificatio-wjnSzH.patch Patch doesn't apply. But very easy to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123723|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 131538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131538&action=edit Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Thanks a lot for testing Samu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131538|0 |1 is obsolete| | --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 131781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131781&action=edit Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Looks good, works as expected. Thanks Fridolin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe it should probably be IDs instead of ids? The internet suggests so, but maybe we could still have a native speaker weigh in? Example: <li><a href="#enterlist_tab">Enter a list of record ids</a></li> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131781|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133713&action=edit Bug 28840: Better texts in batch record modification/deletion Tools batch record modification/deletion form contains texts in legends, labels, hints. I feel like : Labels are sometimes too long, showing them on multi-lines, like "Modify record using the following template". Long texts should be in legend or hint. Legend are sometimes contains redundant text, like in tabs. Also I propose to use "record id" instead of "record number". Test plan : Compare texts in page without and with patch Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133714&action=edit Bug 28840: (QA follow-up) Update id to ID Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #9)
I believe it should probably be IDs instead of ids? The internet suggests so, but maybe we could still have a native speaker weigh in?
Example: <li><a href="#enterlist_tab">Enter a list of record ids</a></li>
I didn't get a reply, so I have decided to provide a follow-up patch for consideration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133714|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133729&action=edit Bug 28840: (QA follow-up) Update id to ID Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #12)
I didn't get a reply, so I have decided to provide a follow-up patch for consideration.
I agree with your change! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #14)
(In reply to Katrin Fischer from comment #12)
I didn't get a reply, so I have decided to provide a follow-up patch for consideration.
I agree with your change!
Thx for the feedback! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28840 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org