[Bug 30596] New: api/v1/acquisitions_baskets.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Bug ID: 30596 Summary: api/v1/acquisitions_baskets.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Because of date comparison 03:57:34 koha_1 | # Failed test 'exact match for JSON Pointer ""' 03:57:34 koha_1 | # at t/db_dependent/api/v1/acquisitions_baskets.t line 59. 03:57:34 koha_1 | # Structures begin differing at: 03:57:34 koha_1 | # $got->[1]{updated_on} = '2022-04-22T01:54:35+00:00' 03:57:34 koha_1 | # $expected->[1]{updated_on} = '2022-04-22T01:54:34+00:00' 03:57:34 koha_1 | # Looks like you failed 1 test of 3. 03:57:34 koha_1 | 03:57:34 koha_1 | # Failed test 'list_managers() tests' 03:57:34 koha_1 | # at t/db_dependent/api/v1/acquisitions_baskets.t line 63. 03:57:34 koha_1 | # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133656&action=edit Bug 30596: Prevent api/v1/acquisitions_baskets.t to fail randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is a bit ugly, and we will need to reuse it in (at least) api/v1/acquisitions_funds.t See commit 9bbbed2a4024311cbbd9b828eba0512f63069735 Bug 30055: API unit tests Tomas, did you deal with that already in other REST api tests? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #2)
This is a bit ugly, and we will need to reuse it in (at least) api/v1/acquisitions_funds.t
See commit 9bbbed2a4024311cbbd9b828eba0512f63069735 Bug 30055: API unit tests
Tomas, did you deal with that already in other REST api tests?
Maybe we need a new is_deeply, that accepts a list of things to exclude in the comparisson? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
This is a bit ugly, and we will need to reuse it in (at least) api/v1/acquisitions_funds.t
See commit 9bbbed2a4024311cbbd9b828eba0512f63069735 Bug 30055: API unit tests
Tomas, did you deal with that already in other REST api tests?
Why not: + $superlibrarian->discard_changes; + $patron_with_permission->discard_changes; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Nick Clemens from comment #4)
(In reply to Jonathan Druart from comment #2)
This is a bit ugly, and we will need to reuse it in (at least) api/v1/acquisitions_funds.t
See commit 9bbbed2a4024311cbbd9b828eba0512f63069735 Bug 30055: API unit tests
Tomas, did you deal with that already in other REST api tests?
Why not: + $superlibrarian->discard_changes; + $patron_with_permission->discard_changes;
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133656|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133668&action=edit Bug 30596: Prevent api/v1/acquisitions_baskets.t to fail randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #4)
(In reply to Jonathan Druart from comment #2)
This is a bit ugly, and we will need to reuse it in (at least) api/v1/acquisitions_funds.t
See commit 9bbbed2a4024311cbbd9b828eba0512f63069735 Bug 30055: API unit tests
Tomas, did you deal with that already in other REST api tests?
Why not: + $superlibrarian->discard_changes; + $patron_with_permission->discard_changes;
Yes, I think I actually focused on the wrong thing. updated_on is modified because of the set_password call. Having an up-to-date object should fix the problem. Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133668|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133669&action=edit Bug 30596: Prevent api/v1/acquisitions_baskets.t and api/v1/acquisitions_funds.t to fail randomly because of updated_on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133669|0 |1 is obsolete| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 133693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133693&action=edit Bug 30596: Prevent api/v1/acquisitions_baskets.t and api/v1/acquisitions_funds.t to fail randomly because of updated_on Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133693|0 |1 is obsolete| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 133845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133845&action=edit Bug 30596: Prevent api/v1/acquisitions_baskets.t and api/v1/acquisitions_funds.t to fail randomly because of updated_on Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30596 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org