[Bug 11033] New: In basketgroup pages, Save button and Cancel link are hidden by chooselanguage bar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 Bug ID: 11033 Summary: In basketgroup pages, Save button and Cancel link are hidden by chooselanguage bar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org In basketgroup pages, Save button and Cancel link are hidden by chooselanguage bar This is caused by the css declaration setting body margin and padding in basketgroup.tt to 0. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 21943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21943&action=edit [PATCH] Bug 11033 Make Save button and Cancel link always visible on basketgroup page This patch suppress the first CSS declaration in basketgroup.tt. It was unneeded, and was the cause of the Save button and Cancel link not being visible if the bar for changing language was activated. To test : 1. activate the "language" syspref, with at least 2 languages 2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at the bottom of basketgroup page 3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- By the way, the code of this template file is pretty ugly, but that's not the problem here ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21962&action=edit Bug 11033 Make Save button and Cancel link always visible on basketgroup page This patch suppress the first CSS declaration in basketgroup.tt. It was unneeded, and was the cause of the Save button and Cancel link not being visible if the bar for changing language was activated. To test : 1. activate the "language" syspref, with at least 2 languages 2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at the bottom of basketgroup page 3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * code removal only * passes koha-qa.pl (of course, considering it's removing code only) * regression test = everything fine if there's no language bar with the patch (as it was without) passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21962|0 |1 is obsolete| | --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22191&action=edit Bug 11033 Make Save button and Cancel link always visible on basketgroup page This patch suppress the first CSS declaration in basketgroup.tt. It was unneeded, and was the cause of the Save button and Cancel link not being visible if the bar for changing language was activated. To test : 1. activate the "language" syspref, with at least 2 languages 2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at the bottom of basketgroup page 3. Check you can use the basketgroup as before : put a basket in it, cancel, save etc. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.poulain@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Paul Poulain from comment #5)
QA comment: * code removal only * passes koha-qa.pl (of course, considering it's removing code only) * regression test = everything fine if there's no language bar with the patch (as it was without)
passed QA
I did think of regression test ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org