[Bug 10619] New: sco.css missing for CCSR OPAC templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Bug ID: 10619 Summary: sco.css missing for CCSR OPAC templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To test: - Activate prog OPAC theme and web based self check - Open the web based self check page in OPAC - Verify it displays ok - Switch OPAC theme to CCSR - Verify the pages changes: On the left appears some information that should not be there. In the logs following error message should only appear when using CCSR templates: [Sun Jul 21 11:32:57 2013] [error] [client 127.0.0.1] File does not exist: /home/katrin/kohaclone/koha-tmpl/opac-tmpl/ccsr/famfamfam, referer: http://localhost/opac-tmpl/ccsr/en/css/sco.css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: System preference OpacFavicon is not used for web based self check pages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20041&action=edit Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20041|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 20054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20054&action=edit [SIGNED-OFF] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20594&action=edit [PASSED QA] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> CSS changes only, works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20054|0 |1 is obsolete| | Attachment #20594|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20595&action=edit [PASSED QA] Bug 10619 - sco.css missing for CCSR OPAC templates sco.css is not missing from CCSR, but some image paths in the CSS are incorrect, resulting in some missing images. This patch corrects those broken paths. This patch also hides the Cart/Lists/login region of the template which should not be visible in self checkout. To test, enable self-checkout and switch to the CCSR theme. Load a patron for self-checkout and confirm that images associated with buttons appear correctly: By the help link in the upper-right, on the 'Finish' button, etc. Try checking out an item which is already checked out to that patron to see more examples. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> CSS changes only, works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org