[Bug 10790] New: adding/editing item types screen mis aligned if noItemTypeImages not showing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Bug ID: 10790 Summary: adding/editing item types screen mis aligned if noItemTypeImages not showing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 20661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20661&action=edit add item type See attached. When you have noItemTypeImages set to "Don't show" everything goes wonky on the add item type screen. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Assignee|oleonard@myacpl.org |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26467&action=edit Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing This patch fixes the odd behavior when noItemTypesImages is set to 'Don't show'. Just a misplaced </div> To test: 1) Set syspref noItemTypeImages to 'Don't show' 2) Go to Admininstration > Item types 3) Edit some item type, you will view a display similar to the attached image 4) Apply the patch 5) Reload the page, now the display is fixed 6) Change syspref to 'Show' to check that the display is also good Also fixed a missing '/' on a closing select -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- *** Bug 11424 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26467|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26480&action=edit [SIGNED OFF] Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing This patch fixes the odd behavior when noItemTypesImages is set to 'Don't show'. Just a misplaced </div> To test: 1) Set syspref noItemTypeImages to 'Don't show' 2) Go to Admininstration > Item types 3) Edit some item type, you will view a display similar to the attached image 4) Apply the patch 5) Reload the page, now the display is fixed 6) Change syspref to 'Show' to check that the display is also good Also fixed a missing '/' on a closing select Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26480|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26483&action=edit Bug 10790 - adding/editing item types screen mis aligned if noItemTypeImages not showing This patch fixes the odd behavior when noItemTypesImages is set to 'Don't show'. Just a misplaced </div> To test: 1) Set syspref noItemTypeImages to 'Don't show' 2) Go to Admininstration > Item types 3) Edit some item type, you will view a display similar to the attached image 4) Apply the patch 5) Reload the page, now the display is fixed 6) Change syspref to 'Show' to check that the display is also good Also fixed a missing '/' on a closing select Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10790 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org