http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27217&action=edit Bug 12094 - jQueryUI upgrade broke default tab selection The recent upgrade to jQueryUI didn't take into account the new method for forcing selection of a tab by adding a class to the tab markup. This patch corrects this by updating the class name. This patch also updates one instance where it was necessary to switch to the new function for selecting a tab by ID, introduced by Bug 12075. To test, view the following pages: - Perform a catalog search in the staff client. On the search results page the "Search the catalog" tab should be selected. - In Acquisitions, view the basket groups page for a vendor which has open and closed basket groups (/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=X). Append "&listclosed=1" to the URL. The "Closed" tab should be selected. - In Administration -> Authorized values, modify an authorized value for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Administration -> Item types, modify an itemtype for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Cataloging, open an existing record and select any tab besides the first one. Choose "Save and continue editing" from the Save menu. When the page reloads you should be returned to the tab you selected before. - In Suggestions, markup for selected the tab has been removed because it didn't appear to be performing any function. The first tab is selected by default. The template doesn't need to explicitly add a class to make it so. - In Tools -> CSV profiles, choose an existing profile for editing. When the page loads the "Edit existing profile" tab should be selected. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27217|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 27351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27351&action=edit [SIGNED OFF] Bug 12094 - jQueryUI upgrade broke default tab selection The recent upgrade to jQueryUI didn't take into account the new method for forcing selection of a tab by adding a class to the tab markup. This patch corrects this by updating the class name. This patch also updates one instance where it was necessary to switch to the new function for selecting a tab by ID, introduced by Bug 12075. To test, view the following pages: - Perform a catalog search in the staff client. On the search results page the "Search the catalog" tab should be selected. - In Acquisitions, view the basket groups page for a vendor which has open and closed basket groups (/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=X). Append "&listclosed=1" to the URL. The "Closed" tab should be selected. - In Administration -> Authorized values, modify an authorized value for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Administration -> Item types, modify an itemtype for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Cataloging, open an existing record and select any tab besides the first one. Choose "Save and continue editing" from the Save menu. When the page reloads you should be returned to the tab you selected before. - In Suggestions, markup for selected the tab has been removed because it didn't appear to be performing any function. The first tab is selected by default. The template doesn't need to explicitly add a class to make it so. - In Tools -> CSV profiles, choose an existing profile for editing. When the page loads the "Edit existing profile" tab should be selected. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Unable to duplicate Cataloging step issue, but there is no visible regression with the patch. The second part of the addbiblio.tt portion of the patch is clearly correct, because it is the same type of change as made in the other sections. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27351|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27390&action=edit Bug 12094 - jQueryUI upgrade broke default tab selection The recent upgrade to jQueryUI didn't take into account the new method for forcing selection of a tab by adding a class to the tab markup. This patch corrects this by updating the class name. This patch also updates one instance where it was necessary to switch to the new function for selecting a tab by ID, introduced by Bug 12075. To test, view the following pages: - Perform a catalog search in the staff client. On the search results page the "Search the catalog" tab should be selected. - In Acquisitions, view the basket groups page for a vendor which has open and closed basket groups (/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=X). Append "&listclosed=1" to the URL. The "Closed" tab should be selected. - In Administration -> Authorized values, modify an authorized value for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Administration -> Item types, modify an itemtype for which an icon has been selected. When the edit form loads the corresponding icon tab should be selected. - In Cataloging, open an existing record and select any tab besides the first one. Choose "Save and continue editing" from the Save menu. When the page reloads you should be returned to the tab you selected before. - In Suggestions, markup for selected the tab has been removed because it didn't appear to be performing any function. The first tab is selected by default. The template doesn't need to explicitly add a class to make it so. - In Tools -> CSV profiles, choose an existing profile for editing. When the page loads the "Edit existing profile" tab should be selected. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Unable to duplicate Cataloging step issue, but there is no visible regression with the patch. The second part of the addbiblio.tt portion of the patch is clearly correct, because it is the same type of change as made in the other sections. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12094 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.