https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 158101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158101&action=edit Bug 35192: Highlight search terms in the OPAC Title notes tab Test plan: 1. Create a biblio record with the word 'Fish' in the title (245$a) and the summary (520$a) 2. Set 'OpacHighlightedWords' system preference to 'Highlight' 3. Submit an OPAC search with the search term of 'Fish'. Click on the biblio created in #1 4. Notice 'Fish' in the title is highlighted, as is the Summary. Scroll down to the Holdings table. Click on 'Title notes' and notice 'Fish' is not highlighted in the 'Title notes' 5. Apply patch and restart services 6. Refresh the biblio page. Click on the 'Title notes' tab again 7. Notice 'Fish' is highlighted in the 'Title notes' tab 8. Right click, click 'Inspect element'. Confirm there are no JavaScript errors in the console. Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> ---

From my testing, words in the title notes tab are not highlighted.

The only JS error in the console is about downloadable fonts - there is a bug for this (Bug 34973). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 189918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189918&action=edit Bug 35192: Highlight search terms in the OPAC Title notes tab Test plan: 1. Create a biblio record with the word 'Fish' in the title (245$a) and the summary (520$a) 2. Set 'OpacHighlightedWords' system preference to 'Highlight' 3. Submit an OPAC search with the search term of 'Fish'. Click on the biblio created in #1 4. Notice 'Fish' in the title is highlighted, as is the Summary. Scroll down to the Holdings table. Click on 'Title notes' and notice 'Fish' is not highlighted in the 'Title notes' 5. Apply patch and restart services 6. Refresh the biblio page. Click on the 'Title notes' tab again 7. Notice 'Fish' is highlighted in the 'Title notes' tab 8. Right click, click 'Inspect element'. Confirm there are no JavaScript errors in the console. Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to David Nind from comment #2)

From my testing, words in the title notes tab are not highlighted.

The only JS error in the console is about downloadable fonts - there is a bug for this (Bug 34973).

Hi David, It was lovely to see you last week at Kohacon!! I've reworked this fix and have tested on main in Google Chrome and Mozilla Firefox. Could you please re-test when you have a moment and let me know if the test problems you found in comment #2 are now resolved? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|When your library has the |This enhancement highlights release notes|OpacHighlightedWords system |matching search terms in |preference set to |the OPAC record details |'Highlight', this bugfix |page notes tab (when the |highlights matching search |OpacHighlightedWords system |terms in the OPAC biblio |preference is set to |detail page's title notes |'Highlight'). |tab. | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190001|0 |1 is obsolete| | --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 190691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190691&action=edit Bug 35192: Highlight search terms in the OPAC Title notes tab Test plan: 1. Create a biblio record with the word 'Fish' in the title (245$a) and the summary (520$a) 2. Set 'OpacHighlightedWords' system preference to 'Highlight' 3. Submit an OPAC search with the search term of 'Fish'. Click on the biblio created in #1 4. Notice 'Fish' in the title is highlighted, as is the Summary. Scroll down to the Holdings table. Click on 'Title notes' and notice 'Fish' is not highlighted in the 'Title notes' 5. Apply patch and restart services 6. Refresh the biblio page. Click on the 'Title notes' tab again 7. Notice 'Fish' is highlighted in the 'Title notes' tab 8. Right click, click 'Inspect element'. Confirm there are no JavaScript errors in the console. Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35192 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloe.zermatten@openfifth.c | |o.uk --- Comment #9 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Not backporting to 25.11.x (stable) as it's an enhancement / new feature. Happy to reconsider if needed! -- You are receiving this mail because: You are watching all bug changes.