[Bug 32736] New: koha-worker should be able to restart all queues with a single call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Bug ID: 32736 Summary: koha-worker should be able to restart all queues with a single call Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Maybe a --queue all or something? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35092 [Bug 35092] [OMNIBUS] Remaining background job/worker issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff Depends on| |31124 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Working in the area and this seems trivial with bug 31124 addition. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31124 [Bug 31124] koha-remove fails to remove long_tasks queue daemon, so koha-create for same <instance> user fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182708&action=edit Bug 32736: Add --all-queues switch to koha-worker This patch adds a convenient option switch to the script. It will make it perform the action (start, stop, restart, print status) on all defined queues ('default' and 'long_tasks', as of today). To test, make sure you applied bug 31124: 0. Apply this patch 1. Run: $ ktd --shell --root k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh 2. Play with all the options for: k$ debian/scripts/koha-worker * kohadev => SUCCESS: All options work as expected! Note: you should include (say) having `long_tasks` stopped, and starting all workers with the new parameter. And the same for `--stop` and `--start`. 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182710&action=edit Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Command-line Utilities |and plumbing | CC| |nick@bywatersolutions.com, | |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Sorry: $ git bz apply 32736 Bug 32736 Depends on bug 31124 (Signed Off) Follow? [(y)es, (n)o] y Bug 31124 - koha-remove fails to remove long_tasks queue daemon, so koha-create for same <instance> user fails 182714 - Bug 31124: Make koha-remove stop all workers Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31124: Make koha-remove stop all workers Bug 32736 - koha-worker should be able to restart all queues with a single call 182708 - Bug 32736: Add --all-queues switch to koha-worker 182710 - Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32736: Add --all-queues switch to koha-worker Applying: Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues error: sha1 information is lacking or useless (debian/scripts/koha-create). error: could not build fake ancestor Patch failed at 0001 Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32736-follow-up-Make-scripts-using-koha-worker-NyF0sC.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182708|0 |1 is obsolete| | Attachment #182710|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185252&action=edit Bug 32736: Add --all-queues switch to koha-worker This patch adds a convenient option switch to the script. It will make it perform the action (start, stop, restart, print status) on all defined queues ('default' and 'long_tasks', as of today). To test, make sure you applied bug 31124: 0. Apply this patch 1. Run: $ ktd --shell --root k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh 2. Play with all the options for: k$ debian/scripts/koha-worker * kohadev => SUCCESS: All options work as expected! Note: you should include (say) having `long_tasks` stopped, and starting all workers with the new parameter. And the same for `--stop` and `--start`. 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185253&action=edit Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 32736 Bug 32736 - koha-worker should be able to restart all queues with a single call 185252 - Bug 32736: Add --all-queues switch to koha-worker 185253 - Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32736: Add --all-queues switch to koha-worker Using index info to reconstruct a base tree... M debian/scripts/koha-worker Falling back to patching base and 3-way merge... Auto-merging debian/scripts/koha-worker CONFLICT (content): Merge conflict in debian/scripts/koha-worker error: Failed to merge in the changes. Patch failed at 0001 Bug 32736: Add --all-queues switch to koha-worker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190736&action=edit Bug 32736: Add --all-queues switch to koha-worker This patch adds a convenient option switch to the script. It will make it perform the action (start, stop, restart, print status) on all defined queues ('default' and 'long_tasks', as of today). To test, make sure you applied bug 31124: 0. Apply this patch 1. Run: $ ktd --shell --root k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh 2. Play with all the options for: k$ debian/scripts/koha-worker * kohadev => SUCCESS: All options work as expected! Note: you should include (say) having `long_tasks` stopped, and starting all workers with the new parameter. And the same for `--stop` and `--start`. 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190737&action=edit Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues Patch from commit cad1ee2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190736|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 190738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190738&action=edit Bug 32736: Add --all-queues switch to koha-worker This patch adds a convenient option switch to the script. It will make it perform the action (start, stop, restart, print status) on all defined queues ('default' and 'long_tasks', as of today). To test, make sure you applied bug 31124: 0. Apply this patch 1. Run: $ ktd --shell --root k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh 2. Play with all the options for: k$ debian/scripts/koha-worker * kohadev => SUCCESS: All options work as expected! Note: you should include (say) having `long_tasks` stopped, and starting all workers with the new parameter. And the same for `--stop` and `--start`. 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190737|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 190739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190739&action=edit Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds an --all-queues option release notes| |to the koha-worker package | |command. This lets you | |perform actions (such as | |start, stop, restart, and | |status) on all defined | |queues (currently only | |'default' and 'long_tasks') | |with one command. --- Comment #13 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. After applying the patch, I ran reset_all 2. Running koha-worker --help now shows the new options 3. I tested some of the options, and they all seemed to work okay for me: - sudo koha-worker --stop --all-queues kohadev - sudo koha-worker --status kohadev - sudo koha-worker --status --all-queues kohadev - sudo koha-worker --start --queue default kohadev - sudo koha-worker --status --all-queues kohadev - sudo koha-worker --start --all-queues kohadev - sudo koha-worker --start --all-queues kohadev - sudo koha-worker --restart --all-queues kohadev - sudo koha-worker --stop --queue long_tasks kohadev For reference, the updated help with the new --all-queues option: koha-worker This script lets you manage the worker daemon for your Koha instances. Usage: koha-worker [--start|--stop|--restart] [--queue queue_name|--all-queues] [--quiet|-q] instancename1 [instancename2...] koha-worker --status instancename1 [instancename2...] koha-worker -h|--help --start Start the worker daemon for the specified instances --stop Stop the worker daemon for the specified instances --restart Restart the worker daemon for the specified instances --queue Specify the queue/worker to perform the action on - 'default' is used if not specified (unless --all-queues is passed) current queues are: default, long_tasks --all-queues Perform the action on all defined queues --status Show the status of the worker for the specified instances --quiet|-q Make the script quiet about non existent instance names (useful for calling from another scripts). --help|-h Display this help message Note: There used to be a queue called elastic_index, but since the introduction of koha-es-indexer this queue should not be active. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190738|0 |1 is obsolete| | --- Comment #14 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191209&action=edit Bug 32736: Add --all-queues switch to koha-worker This patch adds a convenient option switch to the script. It will make it perform the action (start, stop, restart, print status) on all defined queues ('default' and 'long_tasks', as of today). To test, make sure you applied bug 31124: 0. Apply this patch 1. Run: $ ktd --shell --root k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh 2. Play with all the options for: k$ debian/scripts/koha-worker * kohadev => SUCCESS: All options work as expected! Note: you should include (say) having `long_tasks` stopped, and starting all workers with the new parameter. And the same for `--stop` and `--start`. 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190739|0 |1 is obsolete| | --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191210&action=edit Bug 32736: (follow-up) Make scripts using koha-worker use --all-queues Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32736 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org