[Bug 15340] New: Translatability: fix issue with 'or choose' splitted by <strong> tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Bug ID: 15340 Summary: Translatability: fix issue with 'or choose' splitted by <strong> tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr To verify: - make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 45533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45533&action=edit Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag This patch fixes a translatability issue due to <trong> tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose' To test: - Apply patch - Verify that the <strong> tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45533|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45534&action=edit Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag This patch fixes a translatability issue due to <trong> tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose' To test: - Apply patch - Verify that the <strong> tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Obvious issue/solution -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Translatability: fix issue |Translatability: fix issue |with 'or choose' splitted |with 'or choose' splitted |by <strong> tag |by <strong tag -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45534|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45595&action=edit Bug 15340: Translatability: fix issue with 'or choose' splitted by <strong> tag This patch fixes a translatability issue due to <trong> tags. To verify: - Make sure that you have some entries in 'Cities and Towns' ( Home > Administration > Cities ) - Edit the main address of a patron's details - Locate field "City", at the right you have the text 'or choose' followed by a drop-down ('choose' is bold) - change language e.g. to German, the text reads 'or auswählen' (instead of 'oder auswählen') - This is due to the <strong> tags around 'choose' To test: - Apply patch - Verify that the <strong> tags around 'choose' are removed in: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-de.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style-us.inc Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Obvious issue/solution Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15340 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org