[Bug 26993] New: Allow StoreLastBorrower to retain up to 2 previous patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Bug ID: 26993 Summary: Allow StoreLastBorrower to retain up to 2 previous patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 14945 Various workflows and circumstances can result in the "last returned by" value stored by StoreLastBorrower getting overwritten sooner than a library might like. For example, a patron may find the item they've checked out was damaged by the previous patron. They put the item in the bookdrop on their way into the library and then alert staff to the damage when they check out their next batch of items. By that time, the damaged item has been checked in, our imaginary patron shows as "last returned by," and we have no record there of who had it previously. We could alleviate this by adding a third option to the StoreLastBorrower system preference, so that one can choose "Do not store," "store 1," or "store 2." This entire feature would still be optional for libraries that don't want to keep this data. Additionally, bug 23260 is adding the ability to clear this data after a period of time using cleanup_database. These factors help mitigate the privacy concerns inherent to the matter. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 [Bug 14945] Add the ability to store the last patron to return an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
From an accountability perspective, having the option for libraries to be able to "track" an item's [relatively recent] check-out history would be very helpful. We're not asking to breach anyone's privacy regarding their reading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Wally DesChamps <wdeschamps@prospertx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wdeschamps@prospertx.gov --- Comment #1 from Wally DesChamps <wdeschamps@prospertx.gov> --- preferences; i.e., we're not asking to see a patron's reading history. We're merely trying to maintain a item's history (at least for a while) to determine accountability for damages. I like the idea of a scheduled clean-up database option (that can be determined by library as a cron job of sorts) as a method of making an effort to offer good-faith efforts of privacy. All this said, though, [our] items are government property, and we have an obligation to the taxpayers to be able to manage and track accountability of those items (at least for a window of time). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If we are extending from 1 to 2, why not extend to a defined limit or for a defined period of time? Makes it a bit more flexible? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Erik Stevens <technology@haineslibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |technology@haineslibrary.or | |g --- Comment #3 from Erik Stevens <technology@haineslibrary.org> --- We would love to see this feature. It has come up several times that the item was damaged by the 2nd-to last patron, and we have no record of who that was. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #4 from Wally DesChamps <wdeschamps@prospertx.gov> --- Here are two reports we use. They are effective unless the patron marks their account to not keep their history. Check-Outs in a date range 1 SELECT i.barcode as 'Item Barcode', 2 b.title as 'Title', 3 i.itemcallnumber as 'Item Call Number', 4 a.timestamp as 'Date and Time', 5 concat(borr.surname,", ",borr.firstname) as 'Patron Name', 6 borr.cardnumber as 'Patron Barcode' 7 FROM action_logs a 8 LEFT JOIN borrowers borr on (borr.borrowernumber=a.object) 9 LEFT JOIN items i on (i.itemnumber=a.info) 10 INNER JOIN biblio b on (b.biblionumber=i.biblionumber) 11 WHERE a.action='ISSUE' AND DATE(a.timestamp) BETWEEN <<Between (yyyy-mm-dd)|date>> AND <<and (yyyy-mm-dd)|date>> 12 ORDER BY borr.firstname asc Circulation History of an Item. NOTE: Must edit/save the SQL of the report with the target item’s barcode (in line 14 below). 1 SELECT 2 borrowers.cardnumber as "Cardnumber", 3 borrowers.othernames as "Othername", 4 borrowers.surname as "Surname", 5 items.itype, 6 items.barcode, 7 items.itemcallnumber as "Call Number", 8 date(statistics.datetime) as "Transaction Date", 9 statistics.type as "Transaction Type" 10 FROM borrowers 11 LEFT JOIN statistics on (statistics.borrowernumber=borrowers.borrowernumber) 12 LEFT JOIN items on (items.itemnumber = statistics.itemnumber) 13 LEFT JOIN biblioitems on (biblioitems.biblioitemnumber = items.biblioitemnumber) 14 WHERE items.barcode='21900004456' 15 ORDER BY statistics.datetime DESC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula@hypernova.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow StoreLastBorrower to |Allow StoreLastBorrower to |retain up to 2 previous |retain a locally-defined |patrons |number of previous | |borrowers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186773&action=edit Bug 26993: Database updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186774&action=edit Bug 26993: Schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186775&action=edit Bug 26993: System preference updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186776&action=edit Bug 26993: Implement changes Test plan: 1. APPLY patch, restart_all, updatedatabase 2. Search for the StoreLastBorrower system preference, it should now allow you to enter a number of borrowers to store 3. Set the pref to 3. 4. Check an item out to any patron. Then immediately check it back in. 5. On catalogue/moredetail.pl?biblionumber=X ( where X is you biblionumber ) you should see a "Last returned by:" entry with the correct cardnumber for the borrower. 7. Confirm this is right in the database with: SELECT * FROM items_last_borrower where itemnumber = X; ( Where X is your itemnumber ) 8. Repeat step 4 to a different borrower. 9. Repeat steps 5 and 6. You should see 2 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 10. Repeat step 4 with another new borrower. 11. Repeat steps 5 and 6. You should see 3 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 12. Choose a different item and repeat steps 4 - 11 for this item. 13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in. 15. catalogue/moredetail.pl?biblionumber=X should NOT have an entry for "Last returned by:" 16. Check the database, all entries for the itemnumber from step 14 should be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Note: I removed the if ( C4::Context->preference('StoreLastBorrower') ) {} check from Circulation.pm The reason is because if the pref is off, I still want to delete any stored borrowers in the 'items_last_borrower', in the event that the system preference changed to 0 or nothing. I think it's important to delete these borrowers when things change and it is decided to NOT keep this history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #10 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lucas Gass (lukeg) from comment #9)
The reason is because if the pref is off, I still want to delete any stored borrowers in the 'items_last_borrower', in the event that the system preference changed to 0 or nothing.
I think it's important to delete these borrowers when things change and it is decided to NOT keep this history.
I agree, it is important that the data collection settings we define are consistent to what we actually store in the database. Out of scope for this bug but it would be nice if we had a mechanism for executing a task after a system preference has changed. But since we don't, perhaps we could add items_last_borrower cleanup based on StoreLastBorrower preference in cleanup_database.pl? Great work btw! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186776|0 |1 is obsolete| | --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186801&action=edit Bug 26993: Implement changes Test plan: 1. APPLY patch, restart_all, updatedatabase 2. Search for the StoreLastBorrower system preference, it should now allow you to enter a number of borrowers to store 3. Set the pref to 3. 4. Check an item out to any patron. Then immediately check it back in. 5. On catalogue/moredetail.pl?biblionumber=X ( where X is you biblionumber ) you should see a "Last returned by:" entry with the correct cardnumber for the borrower. 7. Confirm this is right in the database with: SELECT * FROM items_last_borrower where itemnumber = X; ( Where X is your itemnumber ) 8. Repeat step 4 to a different borrower. 9. Repeat steps 5 and 6. You should see 2 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 10. Repeat step 4 with another new borrower. 11. Repeat steps 5 and 6. You should see 3 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 12. Choose a different item and repeat steps 4 - 11 for this item. 13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in. 15. catalogue/moredetail.pl?biblionumber=X should NOT have an entry for "Last returned by:" 16. Check the database, all entries for the itemnumber from step 14 should be deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Lari Taskula from comment #10)
But since we don't, perhaps we could add items_last_borrower cleanup based on StoreLastBorrower preference in cleanup_database.pl?
Bug 23260 shall be forthcoming for deletion of old last borrower info via cleanup_database :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186773|0 |1 is obsolete| | --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186805&action=edit Bug 26993: Database updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186774|0 |1 is obsolete| | --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186806&action=edit Bug 26993: Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186775|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186807&action=edit Bug 26993: System preference updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186801|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186808&action=edit Bug 26993: Implement changes Test plan: 1. APPLY patch, restart_all, updatedatabase 2. Search for the StoreLastBorrower system preference, it should now allow you to enter a number of borrowers to store 3. Set the pref to 3. 4. Check an item out to any patron. Then immediately check it back in. 5. On catalogue/moredetail.pl?biblionumber=X ( where X is you biblionumber ) you should see a "Last returned by:" entry with the correct cardnumber for the borrower. 7. Confirm this is right in the database with: SELECT * FROM items_last_borrower where itemnumber = X; ( Where X is your itemnumber ) 8. Repeat step 4 to a different borrower. 9. Repeat steps 5 and 6. You should see 2 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 10. Repeat step 4 with another new borrower. 11. Repeat steps 5 and 6. You should see 3 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 12. Choose a different item and repeat steps 4 - 11 for this item. 13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in. 15. catalogue/moredetail.pl?biblionumber=X should NOT have an entry for "Last returned by:" 16. Check the database, all entries for the itemnumber from step 14 should be deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186809&action=edit Bug 26993: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement expands release notes| |the StoreLastBorrower | |system preference to allow | |for the retention of a | |locally defined number of | |previous borrowers for a | |given item. This | |enhancement also introduces | |a mechanism that will | |delete any extra borrowers | |stored in the | |items_last_borrower table | |that exceed the number set | |in the StoreLastBorrower | |system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 [Bug 23260] Anonymize (remove) patron data from items_last_borrower -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186844&action=edit Bug 26993: (follow-up) Fix template issue when last_returned_by_all returns 1 result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 186853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186853&action=edit Bug 26993: last_returned_by_all should return an array ref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186805|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187311&action=edit Bug 26993: Database updates Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186806|0 |1 is obsolete| | --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187312&action=edit Bug 26993: Schema changes Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186807|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187313&action=edit Bug 26993: System preference updates Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186808|0 |1 is obsolete| | --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187314&action=edit Bug 26993: Implement changes Test plan: 1. APPLY patch, restart_all, updatedatabase 2. Search for the StoreLastBorrower system preference, it should now allow you to enter a number of borrowers to store 3. Set the pref to 3. 4. Check an item out to any patron. Then immediately check it back in. 5. On catalogue/moredetail.pl?biblionumber=X ( where X is you biblionumber ) you should see a "Last returned by:" entry with the correct cardnumber for the borrower. 7. Confirm this is right in the database with: SELECT * FROM items_last_borrower where itemnumber = X; ( Where X is your itemnumber ) 8. Repeat step 4 to a different borrower. 9. Repeat steps 5 and 6. You should see 2 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 10. Repeat step 4 with another new borrower. 11. Repeat steps 5 and 6. You should see 3 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 12. Choose a different item and repeat steps 4 - 11 for this item. 13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in. 15. catalogue/moredetail.pl?biblionumber=X should NOT have an entry for "Last returned by:" 16. Check the database, all entries for the itemnumber from step 14 should be deleted. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186809|0 |1 is obsolete| | --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187315&action=edit Bug 26993: Unit tests Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186853|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187316&action=edit Bug 26993: last_returned_by_all should return an array ref Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- QA comment: 1. I think removing the FK check in the db rev is enough (see previous patch) 2. last_returned_by_all should return a set (not an arrayref), and $self->_result->last_returned_by->delete_all; should be $self->last_returned_by_all->delete; 3. Maybe last_returned_by_all should be renamed last_borrowers? :) 4. (note) There is certainly something to improve in last_returned_by when removing the last X patrons, but I didn't find something that won't remove readability. 5. (not blocker, thought) not sure we should deal with the purge in this method # If StoreLastBorrower is 0 or disabled, bail without storing anything. Also delete any remaining rows from the table. if ( $max_stored_borrowers == 0 ) { $self->_result->last_returned_by->delete_all; return $self; } 6. last_returned_by is not concurrency-safe, but it shouldn't be a problem here. However we should at least use a transaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187459&action=edit Bug 26993: Use FOREIGN_KEY_CHECKS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187460&action=edit Bug 26993: Use a txn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187483&action=edit Bug 26993: (follow-up) Return Koha::Patron resultset from last_returned_by_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187484&action=edit Bug 26993: (follow-up) Rename last_returned_by_all as last_borrowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks Jonathan for looking and for the follow-ups. I have also included 2 follow-up that I think address all the QA concerns. Setting back to "Signed-off" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Does it make sense to have both "Last returned by" and "Last borrower"/"Previous borrower"? https://snipboard.io/dAvq9o.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #32)
Does it make sense to have both "Last returned by" and "Last borrower"/"Previous borrower"?
These have been confusingly labeled for as long as StoreLastBorrower has been a thing, but they're distinct pieces of data and showing them both is longstanding behavior. Clarifying this display somehow is a great idea that should be pursued in another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #33)
(In reply to Jonathan Druart from comment #32)
Does it make sense to have both "Last returned by" and "Last borrower"/"Previous borrower"?
These have been confusingly labeled for as long as StoreLastBorrower has been a thing, but they're distinct pieces of data and showing them both is longstanding behavior. Clarifying this display somehow is a great idea that should be pursued in another bug.
I have filed Bug 40963. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #23)
13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in.
After doing this, I have problems. items_last_borrower recorded my patron from step 14, even though the syspref is set to zero -- I don't have a "Last returned by" line on moredetail.pl, but the data exists in the database. More distressingly, old_issues has lost the borrowernumber for every checkout to any patron other than the patron used in step 14. old_issues.borrowernumber is NULL for these checkouts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #35)
(In reply to Andrew Fuerste-Henry from comment #23)
13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in.
After doing this, I have problems. items_last_borrower recorded my patron from step 14, even though the syspref is set to zero -- I don't have a "Last returned by" line on moredetail.pl, but the data exists in the database.
More distressingly, old_issues has lost the borrowernumber for every checkout to any patron other than the patron used in step 14. old_issues.borrowernumber is NULL for these checkouts.
I think the problem here is `$self->last_borrowers->delete` which calls Koha::Patrons->delete() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #36)
(In reply to Andrew Fuerste-Henry from comment #35)
(In reply to Andrew Fuerste-Henry from comment #23)
13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in.
After doing this, I have problems. items_last_borrower recorded my patron from step 14, even though the syspref is set to zero -- I don't have a "Last returned by" line on moredetail.pl, but the data exists in the database.
More distressingly, old_issues has lost the borrowernumber for every checkout to any patron other than the patron used in step 14. old_issues.borrowernumber is NULL for these checkouts.
I think the problem here is `$self->last_borrowers->delete` which calls Koha::Patrons->delete()
SHOW CREATE TABLE old_issues: CONSTRAINT `old_issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE SET NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191264&action=edit Bug 26993: Use last_returned_by->delete_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187312|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187315|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187459|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187483|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187484|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191264|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191624&action=edit Bug 26993: Database updates Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191625&action=edit Bug 26993: Schema changes Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191626&action=edit Bug 26993: System preference updates Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191628&action=edit Bug 26993: Implement changes Test plan: 1. APPLY patch, restart_all, updatedatabase 2. Search for the StoreLastBorrower system preference, it should now allow you to enter a number of borrowers to store 3. Set the pref to 3. 4. Check an item out to any patron. Then immediately check it back in. 5. On catalogue/moredetail.pl?biblionumber=X ( where X is you biblionumber ) you should see a "Last returned by:" entry with the correct cardnumber for the borrower. 7. Confirm this is right in the database with: SELECT * FROM items_last_borrower where itemnumber = X; ( Where X is your itemnumber ) 8. Repeat step 4 to a different borrower. 9. Repeat steps 5 and 6. You should see 2 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 10. Repeat step 4 with another new borrower. 11. Repeat steps 5 and 6. You should see 3 cardnumbers of each of the borrowers on catalogue/moredetail.pl?biblionumber=X 12. Choose a different item and repeat steps 4 - 11 for this item. 13. Now set the StoreLastBorrower preference to 0. 14. Using the original item from step 4, check something out to a patron and immediately check it back in. 15. catalogue/moredetail.pl?biblionumber=X should NOT have an entry for "Last returned by:" 16. Check the database, all entries for the itemnumber from step 14 should be deleted. Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191630&action=edit Bug 26993: Unit tests Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191631&action=edit Bug 26993: last_returned_by_all should return an array ref Signed-off-by: Trevor Diamond <trevor.diamond@mainlib.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #45 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191632&action=edit Bug 26993: Use FOREIGN_KEY_CHECKS Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191633&action=edit Bug 26993: Use a txn Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #47 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191634&action=edit Bug 26993: (follow-up) Return Koha::Patron resultset from last_returned_by_all Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #48 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191635&action=edit Bug 26993: (follow-up) Rename last_returned_by_all as last_borrowers Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #49 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191636&action=edit Bug 26993: Use last_returned_by->delete_all Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Coming from here: 17:31:36 < KEY `items_last_borrower_ibfk_1` (`itemnumber`), 17:31:36 ERROR - DB structures are not identical 17:31:36 'diff /tmp/current_db.sql /tmp/upgraded_db.sql && diff -q /tmp/current_db.sql /tmp/upgraded_db.sql || { echo "ERROR - DB structures are not identical" && exit 1; }' exited with value 1 at /kohadevbox/misc4dev/run_tests.pl line 306. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #51)
Coming from here:
17:31:36 < KEY `items_last_borrower_ibfk_1` (`itemnumber`), 17:31:36 ERROR - DB structures are not identical 17:31:36 'diff /tmp/current_db.sql /tmp/upgraded_db.sql && diff -q /tmp/current_db.sql /tmp/upgraded_db.sql || { echo "ERROR - DB structures are not identical" && exit 1; }' exited with value 1 at /kohadevbox/misc4dev/run_tests.pl line 306.
Oops, I think I am wrong. This comes from Bug 23260. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42068 [Bug 42068] Update on bug 26993 breaks items deletions with a corrupted foreign key -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26993 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1223 CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org