[Bug 18570] New: Password recovery e-mail only sent after message queue is processed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Bug ID: 18570 Summary: Password recovery e-mail only sent after message queue is processed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: jens.weber@phsh.ch QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org The password recovery process triggers an e-mail to the patron with a link to reset his or her password. This e-mail is put into the message queue like any other notification (e.g. filled HOLD) and hence only sent the next time process_message_queue.pl is triggered with the time setting in cron.d (the default here being every 15 minutes!). This behavior is not what a user would expect from such a function (especially not with the wording from opac-password-recovery.tt: 'An email **has been sent**'). Accordingly -- even though this is not a malfunction -- I flagged this a bug and not an enhancement, as from the point of view of the patron it must seem to be a bug/problem if the e-mail does not arrive in a normal time span. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jens Weber <jens.weber@phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |koha-bugs@lists.koha-commun | |ity.org Component|Authentication |Notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #1 from Sally Healey <sally.healey@cheshiresharedservices.gov.uk> --- Yes, we would really like to see this as well. Bug 17648 remarks on how the ACCTDETAILS notice bypasses message_queue, and is sent directly to the linux mail queue (consequently, the message isn't logged in notices.pl). It would be good if the password recovery e-mail behaved in the same way. An instant e-mail is the response the patron is looking for, and staff do not need to see how many times a password reset has been requested by the patron; it is unnecessary clutter in the notices.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- All our notifications should be sent through the same process (message_queue). What we should do is using a daemon to watch this table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #2)
All our notifications should be sent through the same process (message_queue).
What we should do is using a daemon to watch this table.
I agree, but at the moment a shorter interval breaks CHECKOUT and CHECKIN - those need to be handled separately or be rewritten in a better way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #3)
(In reply to Jonathan Druart from comment #2)
All our notifications should be sent through the same process (message_queue).
What we should do is using a daemon to watch this table.
I agree, but at the moment a shorter interval breaks CHECKOUT and CHECKIN - those need to be handled separately or be rewritten in a better way.
Maybe send such mails immediately and add the message with status "sent" to the table? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If someone plans to work on it, please contact us on the list first :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marc Véron from comment #4)
(In reply to Katrin Fischer from comment #3)
(In reply to Jonathan Druart from comment #2)
All our notifications should be sent through the same process (message_queue).
What we should do is using a daemon to watch this table.
I agree, but at the moment a shorter interval breaks CHECKOUT and CHECKIN - those need to be handled separately or be rewritten in a better way.
Maybe send such mails immediately and add the message with status "sent" to the table?
CHECKIN and CHECKOUT need to be sent when the circulation session is over ideally, so you have one email with all information. For the other emails - that would work, but feels like a bit of a workaround. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 David Kuhn <techservspec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18775 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jens Weber <jens.weber@phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #7 from Jens Weber <jens.weber@phsh.ch> --- I wonder if this (sending of password recovery messages as well as CHECKIN/-OUT notices) could not be achieved by putting them in the message queue (i.e. the default behaviour) and then have misc/cronjobs/process_message_queue.pl triggered 'manually' by the relevant script. For CHECKIN/CHECKOUT this would obviously happen rather often (maybe too often?), but for password recovery -- rarely more than once an hour -- I can't see how it would pose any problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@informaticsgloba | |l.com, | |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 mark.gavillet@ptfs-europe.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mark.gavillet@ptfs-europe.c |ity.org |om CC| |mark.gavillet@ptfs-europe.c | |om --- Comment #8 from mark.gavillet@ptfs-europe.com --- Created attachment 72499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72499&action=edit Patch for bug 18570 Adds a new subroutine to C4/Letters.pm which sends the password reset email to the borrower through the message queue immediately. To test, set the syspref "OpacResetPassword" to "allowed", create a patron with an email address in their record, then click the "Forgotten password" link on the login screen. The new subroutine will match on borrowernumber and letter_code='PASSWORD_RESET' in the message queue and process the single entry, marking it as sent. If your mail server is not enabled, check the mail server logs to see the attempted send (e.g. /var/log/exim4/mainlog) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 72499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72499 Patch for bug 18570 Review of attachment 72499: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18570&attachment=72499) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +1080,5 @@
+Messages from the `message_queue` table are matched on borrowernumber and letter_code='PASSWORD_RESET' + +=cut + +sub SendPasswordEmailFromQueue {
I believe this is the wrong way to do it. I think building a hash ref in SendQueuedMessages and using the built hashref on the _get_unsent_messages call would be better than introducing this, and this fails to handle how to send messages. After all, calling it with a borrower number and a letter code in the params hash ref should be easy enough to add, and then you could simply tweak the t/db_dependent/Letters.t test to test for the password reset case. @@ +1299,4 @@
my @query_params = ('pending'); if ( ref $params ) { if ( $params->{'message_transport_type'} ) { + $statement .= ' AND mq.message_transport_type = ? ';
Not necessary, but okay. There is only one message_transport_type field. @@ +1303,4 @@
push @query_params, $params->{'message_transport_type'}; } if ( $params->{'borrowernumber'} ) { + $statement .= ' AND mq.borrowernumber = ? ';
Not necessary, but okay. The LEFT JOIN makes sure the number is the same, and there is only one borrowernumber in the SELECT list of the SQL statement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset@hotmail.com --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Failed QA for one major reason: Missing test coverage. Do not modify C4 or Koha libraries without including tests. Also, because I think it is the wrong way to do it, but test coverage either way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to M. Tompsett from comment #10)
Failed QA for one major reason: Missing test coverage.
Do not modify C4 or Koha libraries without including tests. Also, because I think it is the wrong way to do it, but test coverage either way.
Hi Mark, if you think it's the wrong way to do it, please explain. It makes no sense to write tests when the idea of the patch needs to be changed later on. I was thinking the routine might be better not so single purpose. I think there might be other use cases like the patron registration verification emails (I even think there is a bug about those already) that we will want to send immediately. I Maybe just needs the letter code as parameter and a more general name? Could there be a scenario where we have a race condition? Entry not yet written to message_queue and tryint to send it or similar? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #11)
Hi Mark, if you think it's the wrong way to do it, please explain.
"I think building a hash ref in SendQueuedMessages and using the built hashref on the _get_unsent_messages call would be better than introducing this, and this fails to handle how to send messages."
It makes no sense to write tests when the idea of the patch needs to be changed later on.
In this case, the tests could have been easily tweaked and pushed into t/db_dependent/Letter.t, but I understand why you say that.
I was thinking the routine might be better not so single purpose.
-- which is why I suggested re-working SendQueuedMessages just a little.
I think there might be other use cases like the patron registration verification emails (I even think there is a bug about those already) that we will want to send immediately.
True, which is what this tweak suggesting would aid in setting up for.
Maybe just needs the letter code as parameter and a more general name?
No, because I was thinking...
Could there be a scenario where we have a race condition? Entry not yet written to message_queue and trying to send it or similar?
Of this. This is why I said borrowernumber too. You aren't likely to have the same borrower trying to send the same letter, except mid-upgrade when the borrower has gone all "reset, it's not here, reset, it's not here, reset, it's not here" and generated multiple resets. So the whole $pw->[0] doesn't work. Another reason to use SendQueuedMessages. "After all, calling it with a borrower number and a letter code in the params hash ref should be easy enough to add, and then you could simply tweak the t/db_dependent/Letters.t test to test for the password reset case." You'll notice I quoted what I said in comment #9, because I thought I was clear enough. Sorry that I wasn't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry Mark, totally missed comment#9. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72524&action=edit Bug 18570: Tests to prove if email send was attempted kshell prove -v t/db_dependent/Passwordrecovery.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72525&action=edit Bug 18570: Prove that the letter code parameter tweaks work Run the following commands: kshell prove -v t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72526&action=edit Bug 18570: Send Password Reset Emails immediately Run through the password reset process, and your server should send the message immediate, not waiting for the cronjob. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- If you think the first patch is worthy of sign off, then go ahead and obsolete my three counter patches. Otherwise, apply my first patch alone, and the test should fail. Apply all my patches, and all the tests should pass. And, attempt a password reset process, the email should be sent immediately (it won't be 'pending' in the DB for more than a few seconds). I believe this has sufficient test coverage, and is a better solution by using the existing function. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #18 from mark.gavillet@ptfs-europe.com --- It's all very subjective so I'm happy either way. It would be good to come to a resolution on this one as we've got a couple of customers waiting on this who would be delighted to see it come through! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72531&action=edit Bug 18570: Tests to prove if email send was attempted kshell prove -v t/db_dependent/Passwordrecovery.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72525|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72532&action=edit Bug 18570: Prove that the letter code parameter tweaks work Run the following commands: kshell prove -v t/db_dependent/Letters.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72526|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72533&action=edit Bug 18570: Send Password Reset Emails immediately Run through the password reset process, and your server should send the message immediate, not waiting for the cronjob. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Attachment #72524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- I signed of counter patch, as it is a bit more generall solution and also tested. But thanks you both all for good job done ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Failed QA --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Patch works as expected and tests pass, but: - POD of SendQueuedMessages need to be updated - Also, minimal POD for _get_unsent_messages would be a nice addition -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 72597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72597&action=edit Bug 18570: QA Followup - Improved POD This tweaks the perldoc for SendQueuedMessages and adds some for _get_unsent_messages. TEST PLAN --------- perldoc C4::Letters -- look at _add_attachments (ugly), _get_unsent_messages (non-existent), SendQueuedMessages (no reference to borrowernumber or letter_code). apply patch perldoc C4::Letters -- confirm that SendQueuedMessages and _get_unsent_messages have reasonable POD information. -- notice how _add_attachments' POD is now readable run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- Changing to signed off, as POD doesn't affect code, and the Failed QA reason in comment #23 is solely POD. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72531|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72599&action=edit Bug 18570: Tests to prove if email send was attempted kshell prove -v t/db_dependent/Passwordrecovery.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72532|0 |1 is obsolete| | --- Comment #27 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72600&action=edit Bug 18570: Prove that the letter code parameter tweaks work Run the following commands: kshell prove -v t/db_dependent/Letters.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72533|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72601&action=edit Bug 18570: Send Password Reset Emails immediately Run through the password reset process, and your server should send the message immediate, not waiting for the cronjob. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72597|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 72602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72602&action=edit Bug 18570: QA Followup - Improved POD This tweaks the perldoc for SendQueuedMessages and adds some for _get_unsent_messages. TEST PLAN --------- perldoc C4::Letters -- look at _add_attachments (ugly), _get_unsent_messages (non-existent), SendQueuedMessages (no reference to borrowernumber or letter_code). apply patch perldoc C4::Letters -- confirm that SendQueuedMessages and _get_unsent_messages have reasonable POD information. -- notice how _add_attachments' POD is now readable run koha qa test tools Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Thanks for the follow-up Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed Assignee|mark.gavillet@ptfs-europe.c |mtompset@hotmail.com |om | --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please provide a follow-up patch to remove these warnings: t/db_dependent/Passwordrecovery.t .. 1/20 Bad or missing From address: 'aWNWJnrqfp' at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 164. Bad or missing From address: 'aWNWJnrqfp' at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 164. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #33 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73221&action=edit Bug 18570: Follow up to fix test noise This sets a valid email and changes the tests to expect it was sent. prove t/db_dependent/Passwordrecovery.t -- noise before patch -- no noise after patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #34 from M. Tompsett <mtompset@hotmail.com> --- Just the last patch as the rest are on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20474 [Bug 20474] Passwordrecovery.t should mock Mail::Sendmail::sendmail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #33)
Created attachment 73221 [details] [review] Bug 18570: Follow up to fix test noise
Pushed to master. Please take a look at bug 20474. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, backported to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #37 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I must find time to test this properly for backport on 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org