[Bug 27125] New: Show authority type for UNIMARC in authority search result display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Bug ID: 27125 Summary: Show authority type for UNIMARC in authority search result display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335c... I propose to use result->{authtype} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 [Bug 12533] Improve authority search result display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114072&action=edit Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335c... I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114072|0 |1 is obsolete| | --- Comment #2 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 117469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117469&action=edit Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335c... I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> I followed the test plan, and the patch works as expected for both UNIMARC and MARC21. There is actually an improvement in the MARC21 case: previously, the 'Authority type' column for records in the Default framework would not display anything, whereas now it displays 'Default'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117469|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 119732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119732&action=edit Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335c... I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> I followed the test plan, and the patch works as expected for both UNIMARC and MARC21. There is actually an improvement in the MARC21 case: previously, the 'Authority type' column for records in the Default framework would not display anything, whereas now it displays 'Default'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.06 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org