[Bug 27695] New: Fix style of messages on Elasticsearch configuration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Bug ID: 27695 Summary: Fix style of messages on Elasticsearch configuration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There some error messages on the Elasticsearch configuration page which are unstyled because they're given a class ("error") which doesn't exist in the CSS. There is also a message which I think should be styled as a note since it contains instructions which are always present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116842&action=edit Bug 27695: Fix style of messages on Elasticsearch configuration page This patch makes minor modifications to SCSS and HTML to make messages on the Elasticsearch configuration page more consistent with other interfaces. To test you should have Elasticsearch selected as your search engine. - Apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> Search engine configuration (Elasticsearch) - You should see a full-width "note" style message under the page heading, "Warning: Any changes..." - Click the "Reset mappings" button at the bottom of the page. The confirmation alert you see should appear above the note-style message. - I'm not sure how to trigger an "error" type message on this page, but you can test the updated style by going to Administration -> Currencies and submit a new currency with the same name and symbol as one which already exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116842|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 117282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117282&action=edit Bug 27695: Fix style of messages on Elasticsearch configuration page This patch makes minor modifications to SCSS and HTML to make messages on the Elasticsearch configuration page more consistent with other interfaces. To test you should have Elasticsearch selected as your search engine. - Apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> Search engine configuration (Elasticsearch) - You should see a full-width "note" style message under the page heading, "Warning: Any changes..." - Click the "Reset mappings" button at the bottom of the page. The confirmation alert you see should appear above the note-style message. - I'm not sure how to trigger an "error" type message on this page, but you can test the updated style by going to Administration -> Currencies and submit a new currency with the same name and symbol as one which already exists. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. are 'alert' and an 'error' really the same...? I feel like we should have a clearer global idea of what 'message', 'info', 'alert', 'error' etc mean.. and I'm not even sure that's the definitive list :| -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #3)
Hmm.. are 'alert' and an 'error' really the same...?
I don't know that they are from the point of view of the user. At some point many scripts where modified to use a different method for sending messages to the template. My searches are failing me so I can't find the relevant bug number. When this change was made, many scripts were updated so that the template would display a dialog with an "error" class which was not defined at the time: push @messages, {type => 'error', code => 'error_on_delete' };
From the way this change was made I suspect the use of "error" was intended to serve the same purpose as "alert." In the staff client there are only "message" and "alert" type dialogs in use.
In some places the script has been changed to use the previously-standard "alert," e.g. Bug 22575. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- For what it's worth... The "message" style was originally defined for any kind of message that is informational, i.e. no action is required on the part of the user. <div class="dialog message"> ... </div> The "alert" style was intended for messages which DO require the user to take action: They have to make a choice asked in the dialog, or they have to address the error in the dialog in order to proceed. <div class="dialog alert"> ... </div> The "error" parameter being added to scripts resulted in this markup: <div class="dialog error"> ... </div> ...which was never added as a style in CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for clarifying Owen.. so this patch will actually fix a whole series of 'error' type dialogue boxes.. cool. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I was imagining we could go with something along the lines of Bootstraps native set of colour options.. primary, success, info, warning, danger But these don't entirely lend themselves to our use case here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117282|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117569&action=edit Bug 27695: Fix style of messages on Elasticsearch configuration page This patch makes minor modifications to SCSS and HTML to make messages on the Elasticsearch configuration page more consistent with other interfaces. To test you should have Elasticsearch selected as your search engine. - Apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> Search engine configuration (Elasticsearch) - You should see a full-width "note" style message under the page heading, "Warning: Any changes..." - Click the "Reset mappings" button at the bottom of the page. The confirmation alert you see should appear above the note-style message. - I'm not sure how to trigger an "error" type message on this page, but you can test the updated style by going to Administration -> Currencies and submit a new currency with the same name and symbol as one which already exists. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- After our discussion, I'm happy to call this PQA.. It fixes a class of missing styling in one hit. I still think we could perhaps make a distinction between 'needs attention from staff user' and 'needs attention from administrator' (error vs alert) later down the line perhaps. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #9)
I still think we could perhaps make a distinction between 'needs attention from staff user' and 'needs attention from administrator' (error vs alert) later down the line perhaps.
I agree. I was going to suggest that the distinction be made between "requires the user to make a choice in order to proceed," and "the operation cannot be completed at all for some reason." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Owen Leonard from comment #10)
I agree. I was going to suggest that the distinction be made between "requires the user to make a choice in order to proceed," and "the operation cannot be completed at all for some reason."
I've added it to the dev meeting agenda, thanks Owen :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #6)
Thanks for clarifying Owen.. so this patch will actually fix a whole series of 'error' type dialogue boxes.. cool.
Well, yes, maybe. or not. $ git grep 'class="error"' returns a long non-exhaustive list Quick random test: https://snipboard.io/px5fq4.jpg When receiving, before: https://snipboard.io/jSWMmf.jpg after: https://snipboard.io/AOoUpa.jpg And certainly many more. I don't think we should do that on this bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oops, my bad, I misread the patch. I think this should only apply to 'message boxes' for the moment.. i.e. .message .alert, .message .error ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119428&action=edit Bug 27695: (follow-up) Add specificity to CSS changes This patch moves the definition of .alert and .error classes into the block for .dialog in order to make sure they don't have an effect beyond the desired scope. The ".closebtn" section is redundant and has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117569|0 |1 is obsolete| | Attachment #119428|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119550&action=edit Bug 27695: Fix style of messages on Elasticsearch configuration page This patch makes minor modifications to SCSS and HTML to make messages on the Elasticsearch configuration page more consistent with other interfaces. To test you should have Elasticsearch selected as your search engine. - Apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - Go to Administration -> Search engine configuration (Elasticsearch) - You should see a full-width "note" style message under the page heading, "Warning: Any changes..." - Click the "Reset mappings" button at the bottom of the page. The confirmation alert you see should appear above the note-style message. - I'm not sure how to trigger an "error" type message on this page, but you can test the updated style by going to Administration -> Currencies and submit a new currency with the same name and symbol as one which already exists. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119551&action=edit Bug 27695: (follow-up) Add specificity to CSS changes This patch moves the definition of .alert and .error classes into the block for .dialog in order to make sure they don't have an effect beyond the desired scope. The ".closebtn" section is redundant and has been removed. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27695 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org