[Bug 17733] New: Members.t is still failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Bug ID: 17733 Summary: Members.t is still failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 17713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17713 [Bug 17713] Members.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58005&action=edit Bug 17733: Fix Members.t In some dirty DB (Jenkins), the borrowers.guarantorid field is not set to a valid patron id. That make some tests fail if we create a patron with that patron id. In my DB, auto increment for borrowers is set to 52 before the tests On the 4th run of the tests, some tests fail. Before I got a patron with a guarantorid=112 (I let you do the math). Test plan: The easiest is to trust me Todo: Add a FK! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58005|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 58006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58006&action=edit [SIGNED OFF] Bug 17733: Fix Members.t In some dirty DB (Jenkins), the borrowers.guarantorid field is not set to a valid patron id. That make some tests fail if we create a patron with that patron id. In my DB, auto increment for borrowers is set to 52 before the tests On the 4th run of the tests, some tests fail. Before I got a patron with a guarantorid=112 (I let you do the math). Test plan: The easiest is to trust me Todo: Add a FK! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We need this to make Jenkins go green! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1)
Test plan: The easiest is to trust me
Best plan ever? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. I manipulated guarantorid of some borrower (with your calculation ;) And the first time I ran the test, it failed: not ok 65 - TrackLastPatronActivity - 2 patrons must be deleted # Failed test 'TrackLastPatronActivity - 2 patrons must be deleted' # at t/db_dependent/Members.t line 363. # got: '1' # expected: '2' not ok 66 - TrackLastPatronActivity - 3 patrons must be deleted # Failed test 'TrackLastPatronActivity - 3 patrons must be deleted' # at t/db_dependent/Members.t line 365. # got: '2' # expected: '3' As expected, the test did not fail when running it again. So you need to remove some guarantorids here too. GetBorrowersToExpunge checks for this column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is something different. I would not mind fixing it in the same patch (especially to avoid yet another bug report), but I do not recreate it and so it's hard to fix :) Otherwise we could just set all the guarantorid to null Koha::Patrons->search->update( { guarantorid => null } ); That should do the job. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
This is something different. I would not mind fixing it in the same patch (especially to avoid yet another bug report), but I do not recreate it and so it's hard to fix :)
Otherwise we could just set all the guarantorid to null Koha::Patrons->search->update( { guarantorid => null } );
That should do the job.
Would not mind doing so outside sections where guarantorid is relevant. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17759 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving the problem from comment5 to a new report: bug 17759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17759 [Bug 17759] Fixing theoretical problems with guarantorid in Members.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58006|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 58111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58111&action=edit Bug 17733: Fix Members.t In some dirty DB (Jenkins), the borrowers.guarantorid field is not set to a valid patron id. That make some tests fail if we create a patron with that patron id. In my DB, auto increment for borrowers is set to 52 before the tests On the 4th run of the tests, some tests fail. Before I got a patron with a guarantorid=112 (I let you do the math). Test plan: The easiest is to trust me Todo: Add a FK! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Opened a new report for special case: Bug 17759. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x, will be in 16.11.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17733 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org