[Bug 36431] New: SIP2: Checkin does not show difference between WasTransfered and NeedsTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Bug ID: 36431 Summary: SIP2: Checkin does not show difference between WasTransfered and NeedsTransfer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org If you enable AutomaticItemReturn, SIP will trigger an eventual transfer to home branch when checking in. If disabled, it will not but the station receives an alert to notify the user. But the SIP response for both cases is actually the same. The code shows this: if ($messages->{NeedsTransfer}) { $self->{item}->destination_loc($messages->{NeedsTransfer}); $self->alert_type('04'); # send to other branch } if ($messages->{WasTransfered}) { # set into transit so tell unit $self->{item}->destination_loc($item->homebranch); $self->alert_type('04'); # send to other branch } The destination location will be the same in both cases. And the alert number is the same too. How could the SIP station 'know' that the transfer is done already or still needs to? Both SIP responses contains AO holding branch, AQ destination, CT destination and CV 04. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- As I understand, we cannot change the CV value. This SIP extension stands for "send to other branch". But would it make sense to populate for instance the AF field [screen message] in the response to show that the transfer was already actually created (when AddReturn responded with WasTransfered) ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #1)
As I understand, we cannot change the CV value. This SIP extension stands for "send to other branch".
But would it make sense to populate for instance the AF field [screen message] in the response to show that the transfer was already actually created (when AddReturn responded with WasTransfered) ?
CV is non-standard but is documented at https://help.oclc.org/Library_Management/Amlib/SIP2/SIP2_Manager_procedure/1... 01 - hold for this library 02 - hold for other branch 04 - send to other branch In both of those code paths, there is indeed a real transfer. In the case of WasTransfered, it means a transfer was initiated, but the item has been checked in at the library the transfer originated from, so the destination and location in this case are not the same. Am I mistaken? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #2)
In both of those code paths, there is indeed a real transfer. In the case of WasTransfered, it means a transfer was initiated, but the item has been checked in at the library the transfer originated from, so the destination and location in this case are not the same. Am I mistaken?
We are not talking about the same situation. You describe a valid case where a transfer exists. But I am looking at the situation where the item is in another branch and has been checked out and checked in again. In that case WasTransfered can be set also (depending on AutomaticItemReturn): Circulation L2519- if (C4::Context->preference("AutomaticItemReturn" ) or (C4::Context->preference("UseBranchTransferLimits") and ! IsBranchTransferAllowed($branch, $returnbranch, $item->$BranchTransferLimitsType ) )) { ModItemTransfer($item->itemnumber, $branch, $returnbranch, $transfer_trigger, { skip_record_index => 1 }); $messages->{'WasTransfered'} = $returnbranch; $messages->{'TransferTrigger'} = $transfer_trigger; } else { $messages->{'NeedsTransfer'} = $returnbranch; $messages->{'TransferTrigger'} = $transfer_trigger; } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> ---
We are not talking about the same situation. You describe a valid case where a transfer exists. But I am looking at the situation where the item is in another branch and has been checked out and checked in again. In that case WasTransfered can be set also (depending on AutomaticItemReturn):
Would you be able to write up a test plan demonstrating the incorrect behavior and what should be happening instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165258&action=edit Bug 36431: Add screen message for NeedsTransfer when AutomaticItemReturn is off Test plan: Pick an item (without holds) with homebranch A and holdingbranch B. (My SIP examples use RMA for A, NRD for B.) Enable AutomaticItemReturn. Check in this item at branch B via SIP. * 09N20240422 10000020240422 160000APNRD|AONRD|ABperl01| You should see something like: * 101YNY20240422 105736AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04| Verify too that a transfer was started. Now disable AutomaticItemReturn. Remove the transfer. Check in this item at branch B via SIP. You should see now something like: 101YNY20240422 105515AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04|AFThis item must still be transferred to RMA branch.| Verify that no transfer was started. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 165259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165259&action=edit Bug 36431: Unit tests Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #4)
We are not talking about the same situation. You describe a valid case where a transfer exists. But I am looking at the situation where the item is in another branch and has been checked out and checked in again. In that case WasTransfered can be set also (depending on AutomaticItemReturn):
Would you be able to write up a test plan demonstrating the incorrect behavior and what should be happening instead?
See patch and test plan. Chose to add the message to the case where AutomaticItemReturn is off (by far most installs have it enabled). So no change for them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165258|0 |1 is obsolete| | Attachment #165259|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176670&action=edit Bug 36431: Add screen message for NeedsTransfer when AutomaticItemReturn is off Test plan: Pick an item (without holds) with homebranch A and holdingbranch B. (My SIP examples use RMA for A, NRD for B.) Enable AutomaticItemReturn. Check in this item at branch B via SIP. * 09N20240422 10000020240422 160000APNRD|AONRD|ABperl01| You should see something like: * 101YNY20240422 105736AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04| Verify too that a transfer was started. Now disable AutomaticItemReturn. Remove the transfer. Check in this item at branch B via SIP. You should see now something like: 101YNY20240422 105515AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04|AFThis item must still be transferred to RMA branch.| Verify that no transfer was started. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall (khall) from comment #8)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Great. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176670|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176671&action=edit Bug 36431: Add screen message for NeedsTransfer when AutomaticItemReturn is off Test plan: Pick an item (without holds) with homebranch A and holdingbranch B. (My SIP examples use RMA for A, NRD for B.) Enable AutomaticItemReturn. Check in this item at branch B via SIP. * 09N20240422 10000020240422 160000APNRD|AONRD|ABperl01| You should see something like: * 101YNY20240422 105736AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04| Verify too that a transfer was started. Now disable AutomaticItemReturn. Remove the transfer. Check in this item at branch B via SIP. You should see now something like: 101YNY20240422 105515AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04|AFThis item must still be transferred to RMA branch.| Verify that no transfer was started. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #11 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176672&action=edit Bug 36431: Unit tests Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176671|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178323&action=edit Bug 36431: Add screen message for NeedsTransfer when AutomaticItemReturn is off Test plan: Pick an item (without holds) with homebranch A and holdingbranch B. (My SIP examples use RMA for A, NRD for B.) Enable AutomaticItemReturn. Check in this item at branch B via SIP. * 09N20240422 10000020240422 160000APNRD|AONRD|ABperl01| You should see something like: * 101YNY20240422 105736AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04| Verify too that a transfer was started. Now disable AutomaticItemReturn. Remove the transfer. Check in this item at branch B via SIP. You should see now something like: 101YNY20240422 105515AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04|AFThis item must still be transferred to RMA branch.| Verify that no transfer was started. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176672|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178324&action=edit Bug 36431: Unit tests Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased on tidied codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178323|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179074&action=edit Bug 36431: Add screen message for NeedsTransfer when AutomaticItemReturn is off Test plan: Pick an item (without holds) with homebranch A and holdingbranch B. (My SIP examples use RMA for A, NRD for B.) Enable AutomaticItemReturn. Check in this item at branch B via SIP. * 09N20240422 10000020240422 160000APNRD|AONRD|ABperl01| You should see something like: * 101YNY20240422 105736AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04| Verify too that a transfer was started. Now disable AutomaticItemReturn. Remove the transfer. Check in this item at branch B via SIP. You should see now something like: 101YNY20240422 105515AONRD|ABperl01|AQRMA|AJLearning Perl /|CSH|CTRMA|CV04|AFThis item must still be transferred to RMA branch.| Verify that no transfer was started. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178324|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179075&action=edit Bug 36431: Unit tests Test plan: Run t/db_dependent/SIP/Message.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Clear improvement, well tested, qa happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Enhancement or bug fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP2: Checkin does not show |Checkin does not show |difference between |difference between |WasTransfered and |WasTransfered and |NeedsTransfer |NeedsTransfer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I would keep it as enh. But yes, understand your question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36431 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x I prefer not backport for behavior stability in LTS -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org