[Bug 37273] New: Add ID column to Agreements table in the ERM
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Bug ID: 37273 Summary: Add ID column to Agreements table in the ERM Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Created attachment 168606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168606&action=edit ERM ID number appended to agreement name When creating an Agreement or License in the ERM, an ID number is added to the agreement or license name. If it is necessary for the ID number to be visible, it should be in a separate column from the name. Having the ID number appended to the name is a little confusing (see example image). Another option is to hide the hide ID number if it is not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Keywords| |Academy --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Esther Melander from comment #0)
Created attachment 168606 [details] ERM ID number appended to agreement name
When creating an Agreement or License in the ERM, an ID number is added to the agreement or license name. If it is necessary for the ID number to be visible, it should be in a separate column from the name. Having the ID number appended to the name is a little confusing (see example image). Another option is to hide the hide ID number if it is not needed.
I think this makes sense. @Joubu do we remember the initial reason why we decided the way it is currently? Trying to understand if there are any blockers for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- I guess I just wanted to avoid a new column in the table. We can have it in a separate column if it is more convenient for people. However I would not hide it, in case you want to search/order by the IDs. Not sure to understand why it is considered confusing however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #3 from Esther Melander <esther.melander@bywatersolutions.com> --- It's not clear what the number means. Labeling it makes it understood the number is an ID number. I can see some cases where a number like '#1' is part of a title on the titles table, which can be confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #4 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 169107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169107&action=edit Bug 37273: Added ID column to ERM Agreements and Licenses Tables To test 1. Apply patch, yarn build, restart_all 2. System preferences -> ERMModule -> Enable 3. E-resource management -> Agreements -> "+New Agreement" 4. Notice ID is removed from name and put in it's own column 5. Repeat with licenses table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cubingguy714@gmail.com Assignee|jonathan.druart@gmail.com |cubingguy714@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Comment on attachment 169107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169107 Bug 37273: Added ID column to ERM Agreements and Licenses Tables Review of attachment 169107: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37273&attachment=169107) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue @@ +268,3 @@
{ title: __("Name"), data: "me.name:me.agreement_id",
We can probably also change this to 'me.name' only. ::: koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue @@ +161,3 @@
{ title: __("Name"), data: "me.name:me.license_id",
We can probably also change this to 'me.name' only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 davedaghita <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 davedaghita <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from davedaghita <ddaghita@mckinneytexas.org> --- The ID# column worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 172137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172137&action=edit Bug 37273: (follow-up) Remove parentheses and # from column The new ID column shows numbers like "(#2)". I think the parentheses and hash symbol are unnecessary and inconsistent with the way we do it in other places and should be removed. To test, apply the patch and rebuild the staff interface CSS: Either run 'yarn build' from the command line or if you're using a sandbox, click the "Actions" menu for your sandbox and choose "Build CSS and JS." Follow the previous test plan and confirm that the ID column looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The enhancement adds an ID release notes| |column to the ERM's | |agreement table which is | |configurable through Table | |settings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169107|0 |1 is obsolete| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176740&action=edit Bug 37273: Added ID column to ERM Agreements and Licenses Tables To test 1. Apply patch, yarn build, restart_all 2. System preferences -> ERMModule -> Enable 3. E-resource management -> Agreements -> "+New Agreement" 4. Notice ID is removed from name and put in it's own column 5. Repeat with licenses table Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172137|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176741&action=edit Bug 37273: (follow-up) Remove parentheses and # from column The new ID column shows numbers like "(#2)". I think the parentheses and hash symbol are unnecessary and inconsistent with the way we do it in other places and should be removed. To test, apply the patch and rebuild the staff interface CSS: Either run 'yarn build' from the command line or if you're using a sandbox, click the "Actions" menu for your sandbox and choose "Build CSS and JS." Follow the previous test plan and confirm that the ID column looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178507&action=edit filters out of sync This has caused the filters to become out of sync in agreements, and likely licenses too, haven't tested. Look at picture, the values for the "Description" filter are the "Status" ones, etc. filters_options inside tableOptions needs to be adjusted accordingly. This work is adding more niche specific behavior to specific tables, it's bad practice. This should be built and considered on top of bug 38201. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179119&action=edit Bug 37273: Fix offset for column filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA Keywords| |additional_work_needed --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #11)
Created attachment 178507 [details] filters out of sync
This has caused the filters to become out of sync in agreements, and likely licenses too, haven't tested. Look at picture, the values for the "Description" filter are the "Status" ones, etc.
filters_options inside tableOptions needs to be adjusted accordingly.
Last patch fixes this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up pushed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- It broke ERM/Agreements_spec.ts and ERM/Licenses_spec.ts, please fix ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179636&action=edit Bug 37273: Fix Cypress tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #17)
Created attachment 179636 [details] [review] Bug 37273: Fix Cypress tests
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patch pushed for 25.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40190 [Bug 40190] Agreements: Vendor filter is on wrong column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39951 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39951 [Bug 39951] Column filters are offset in ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40281 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40299 [Bug 40299] Regression - checkout type column still visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40281 [Bug 40281] Patron circulation history page - type column is not hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37273 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org