[Bug 9000] New: misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Priority: P5 - low Change sponsored?: --- Bug ID: 9000 Assignee: gmcharlt@gmail.com Summary: misc/cronjobs/rss/rss.pl uses HTP Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha The file check misc/cronjobs/rss/rss.pl uses HTML::Template::Pro. It should be converted to use Template::Toolkit, or, if it is a legacy script, removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I remember trying to work with this RSS feed generator years ago but I don't think it's used anymore. As far as I know misc/cronjobs/rss can be removed altogether. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #1)
I don't think it's used anymore. No, it is used by several libraries we work for.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Then it desperately needs to be fixed, because we don't want to keep it using HTML::Template::Pro -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #4 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #2)
(In reply to comment #1)
I don't think it's used anymore. No, it is used by several libraries we work for.
Sorry, I've checked and none of our libraries use this, I've mixed up with something else. It can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |yohann.dufour@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10700 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #5 from Yohann Dufour <yohann.dufour@biblibre.com> --- Since misc/cronjobs/rss/rss.pl is not used anymore, it should be removed. Moreover, this file contains old dependencies with the module HTML::Template::Pro. For a new user of Koha, which launchs the test of t/db_dependent/00-strict.t , it prints : t/db_dependent/00-strict.t ............................. 363/? # Failed test 'Syntax check misc/cronjobs/rss/rss.pl' # at /usr/share/perl5/Test/Strict.pm line 394. # Can't locate HTML/Template/Pro.pm in @INC (you may need to install the HTML::Template::Pro module) (@INC contains: installer misc/translator /home/yohann/koha /home/yohann/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl . /home/yohann/koha /home/yohann/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at misc/cronjobs/rss/rss.pl line 30. # BEGIN failed--compilation aborted at misc/cronjobs/rss/rss.pl line 30. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Yohann Dufour <yohann.dufour@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #6 from Yohann Dufour <yohann.dufour@biblibre.com> --- Created attachment 29088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29088&action=edit Bug 9000: the directory misc/cronjobs/rss/ has been removed Since these files are not used anymore, they can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29088|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29127&action=edit [SIGNED-OFF] Bug 9000: the directory misc/cronjobs/rss/ has been removed Since these files are not used anymore, they can be removed. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Files removed, no errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10700 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not entirely sure about removing these, as the feature seems still functional. I managed to create an XML file with the last Acquired records by installing HTP and running ./rss.pl lastAcquired.conf. Of course there are a couple of problems: The generated XML file is currently only available in English, the feature depends on HTP. As the feature is separate to Koha and can easily be restored, I will pass QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29127|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29134&action=edit [PASSED QA] Bug 9000: the directory misc/cronjobs/rss/ has been removed Since these files are not used anymore, they can be removed. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Files removed, no errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch removes RSS related files that still depend on HTP. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- A counter patch migut easily change the syntax and avoid loosing the feature that seems to be used by some libraries. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29134|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30202&action=edit Bug 9000 [1] - Update rss.pl to use Template Toolkit -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30203&action=edit Bug 9000 [2] - Update included examples -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30204&action=edit Bug 9000 [3] - Change conf key from tmpl to template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30205&action=edit Bug 9000 [4] - Update to GPL v3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30204|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30206&action=edit Bug 9000 [3] - Change conf key from tmpl to template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30205|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30207&action=edit Bug 9000 [4] - Update to GPL v3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Cheers for this Kyle, I've raised it with our guys to test and go forth and sign-off. Martin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30202|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30219&action=edit [SIGNED-OFF] Bug 9000 [1] - Update rss.pl to use Template Toolkit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested using script with sample conf files RSS feeds generated are 'well formed' xml Some koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30203|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30220&action=edit [SIGNED-OFF] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30206|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30221&action=edit [SIGNED-OFF] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30207|0 |1 is obsolete| | --- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30222&action=edit [SIGNED-OFF] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30223&action=edit Bug 9000: Followup to fix tabs & closing TT directive -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30219|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30229&action=edit [PASSED QA] Bug 9000 [1] - Update rss.pl to use Template Toolkit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested using script with sample conf files RSS feeds generated are 'well formed' xml Some koha-qa errors fixed in followup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30220|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30230&action=edit [PASSED QA] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30221|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30231&action=edit [PASSED QA] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30222|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30232&action=edit [PASSED QA] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30223|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30233&action=edit [PASSED QA] Bug 9000: Followup to fix tabs & closing TT directive Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Happy to pass QA on this.. thanks so much for getting to this Kyle, and beating my team to sign-off Bernardo meaning I could QA. I took the initiative of taking Bernardo's patch straight to QA as it was simply a white-space fix to make git not complain ;) Go forth and push fair RM ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle!! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #31 from Nicole C. Engard <nengard@gmail.com> --- Hi all, Can someone help me out here and tell me if/how this changes this section of the manual? http://manual.koha-community.org/3.16/en/opacenhancedcontent.html#customrss Thanks! Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org