[Bug 14351] New: Remove given-when from opac-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Bug ID: 14351 Summary: Remove given-when from opac-search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org given ($pathcode) { when ('"ads"') { $template->param('ReturnPath' => '/cgi-bin/koha/opac-search.pl?returntosearch=1'); } when ('"exs"') { $template->param('ReturnPath' => '/cgi-bin/koha/opac-search.pl?expanded_options=1&returntosearch=1'); } default {warn "ReturnPath swith error";} } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13307 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39964&action=edit Bug 14351: Remove given-when from opac-search.pl Reformats given-when to if-elsif-else in opac-search.pl to remove the experimental feature and with it a lot of warnings from the logs. To test: - Do several different advanced searches with and without expanded search options - Verify the link back to the search appears above the results list and works correctly See also: test plan on bug 13307 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 39964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39964 Bug 14351: Remove given-when from opac-search.pl Review of attachment 39964: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14351&attachment=39964) ----------------------------------------------------------------- Lovely code clean up that improves readability! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39964|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40115&action=edit Bug 14351: Remove given-when from opac-search.pl Reformats given-when to if-elsif-else in opac-search.pl to remove the experimental feature and with it a lot of warnings from the logs. To test: - Do several different advanced searches with and without expanded search options - Verify the link back to the search appears above the results list and works correctly See also: test plan on bug 13307 NOTE: Even installed firefox plug in to edit cookies to trigger else case. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40115|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40162&action=edit Bug 14351: Remove given-when from opac-search.pl Reformats given-when to if-elsif-else in opac-search.pl to remove the experimental feature and with it a lot of warnings from the logs. To test: - Do several different advanced searches with and without expanded search options - Verify the link back to the search appears above the results list and works correctly See also: test plan on bug 13307 NOTE: Even installed firefox plug in to edit cookies to trigger else case. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #7 from Liz Rea <wizzyrea@gmail.com> --- Hi, This patch doesn't apply cleanly to 3.18.x. If you feel it should be included, please provide a version for 3.18.x. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14351 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 13307 is not in 3.18, so this is not needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org